From: David Sterba <dsterba@suse.cz>
To: Anand Jain <anand.jain@oracle.com>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH RFC] btrfs: sysfs: bytes_zone_unusable is not under CONFIG_BTRFS_DEBUG
Date: Thu, 12 Aug 2021 17:59:27 +0200 [thread overview]
Message-ID: <20210812155927.GM5047@twin.jikos.cz> (raw)
In-Reply-To: <8585061cc6672a4f3b985b7c387c7a8040af2a73.1628125287.git.anand.jain@oracle.com>
On Thu, Aug 05, 2021 at 09:07:00AM +0800, Anand Jain wrote:
> Sysfs zoned file is under CONFIG_BTRFS_DEBUG (now there is a patch to
> bring it under CONFIG_BLK_DEV_ZONED). But sysfs file bytes_zone_unusable
> has escaped the CONFIG_BTRFS_DEBUG config. There is no problem with this
> as bytes_zone_unusable with no zoned configured shall display 0, so it is
> just a matter of fixing the consistency.
>
> Signed-off-by: Anand Jain <anand.jain@oracle.com>
> ---
> RFC because in my understanding, there is no way to fix this
> inconsistency without failing the ABI compliance test, so it is just
> better to leave it as it is.
Good find but I think we can keep it there unconditionally, that's the
long term plan. Hiding zoned mode behind debug option was meant only for
the beginning until the worst bugs are ironed out.
prev parent reply other threads:[~2021-08-12 16:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-05 1:07 [PATCH RFC] btrfs: sysfs: bytes_zone_unusable is not under CONFIG_BTRFS_DEBUG Anand Jain
2021-08-12 15:59 ` David Sterba [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210812155927.GM5047@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=anand.jain@oracle.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).