From: David Sterba <dsterba@suse.cz>
To: Qu Wenruo <quwenruo.btrfs@gmx.com>
Cc: dsterba@suse.cz, Marcos Paulo de Souza <mpdesouza@suse.com>,
linux-btrfs@vger.kernel.org, dsterba@suse.com, nborisov@suse.com
Subject: Re: [PATCH] btrfs-progs: Drop the type check in init_alloc_chunk_ctl_policy_regular
Date: Wed, 18 Aug 2021 12:35:42 +0200 [thread overview]
Message-ID: <20210818103542.GR5047@twin.jikos.cz> (raw)
In-Reply-To: <04abaf84-12e3-3983-dee4-a5073ec786f1@gmx.com>
On Wed, Aug 18, 2021 at 01:17:46PM +0800, Qu Wenruo wrote:
> On 2021/8/17 下午9:24, David Sterba wrote:
> > On Mon, Aug 09, 2021 at 03:26:13PM -0300, Marcos Paulo de Souza wrote:
> >>
> >> Signed-off-by: Marcos Paulo de Souza <mpdesouza@suse.com>
> >> ---
> >>
> >> This change mimics what the kernel currently does, which is set the stripe_size
> >> regardless of the profile. Any thoughts on it? Thanks!
> >
> > Makes sense to unify that, it works well for the large sizes. Please
> > write tests that verify that the chunk sizes are correct after mkfs on
> > various device sizes. Patch added to devel, thanks.
>
> It in fact makes fsck/025 to fail, bisection points to this patch
> surprisingly.
>
> Now "mkfs.btrfs -f" on a 128M file will just fail.
>
> This looks like a big problem to me though...
This is known that the small filesystem size and intial chunk layout is
not scaled properly, the patch OTOH fixes the more common case where the
normal block group sizes fit and leave enough room for the rest.
Can the test 025 be scaled up so we don't have to create the 128M
filesystem? I'd rather go that way.
next prev parent reply other threads:[~2021-08-18 10:38 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-09 18:26 [PATCH] btrfs-progs: Drop the type check in init_alloc_chunk_ctl_policy_regular Marcos Paulo de Souza
2021-08-09 18:44 ` Nikolay Borisov
2021-08-17 13:24 ` David Sterba
2021-08-18 4:02 ` Anand Jain
2021-08-18 10:40 ` David Sterba
2021-08-18 5:17 ` Qu Wenruo
2021-08-18 5:34 ` Qu Wenruo
2021-08-18 10:35 ` David Sterba [this message]
2021-08-18 11:26 ` Qu Wenruo
2021-08-18 5:27 ` Anand Jain
2021-08-18 5:36 ` Qu Wenruo
2021-08-20 12:29 ` David Sterba
2021-08-21 0:57 ` Qu Wenruo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210818103542.GR5047@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=dsterba@suse.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=mpdesouza@suse.com \
--cc=nborisov@suse.com \
--cc=quwenruo.btrfs@gmx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).