From: Sidong Yang <realwakka@gmail.com>
To: linux-btrfs <linux-btrfs@vger.kernel.org>,
David Sterba <dsterba@suse.cz>,
Nikolay Borisov <nborisov@suse.com>
Cc: Sidong Yang <realwakka@gmail.com>
Subject: [PATCH v2] btrfs: reflink: Initialize return value in btrfs_extent_same()
Date: Fri, 20 Aug 2021 00:41:00 +0000 [thread overview]
Message-ID: <20210820004100.35823-1-realwakka@gmail.com> (raw)
btrfs_extent_same() cannot be called with zero length. This patch add
code that initialize ret as -EINVAL to make it safe.
Signed-off-by: Sidong Yang <realwakka@gmail.com>
---
v2:
- Removed assert and added initializing ret
---
fs/btrfs/reflink.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/fs/btrfs/reflink.c b/fs/btrfs/reflink.c
index 9b0814318e72..864f42198c5c 100644
--- a/fs/btrfs/reflink.c
+++ b/fs/btrfs/reflink.c
@@ -653,6 +653,7 @@ static int btrfs_extent_same(struct inode *src, u64 loff, u64 olen,
u64 i, tail_len, chunk_count;
struct btrfs_root *root_dst = BTRFS_I(dst)->root;
+ ret = -EINVAL;
spin_lock(&root_dst->root_item_lock);
if (root_dst->send_in_progress) {
btrfs_warn_rl(root_dst->fs_info,
--
2.25.1
next reply other threads:[~2021-08-20 0:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-20 0:41 Sidong Yang [this message]
2021-08-20 6:08 ` [PATCH v2] btrfs: reflink: Initialize return value in btrfs_extent_same() Nikolay Borisov
2021-08-20 11:17 ` David Sterba
2021-08-20 11:50 ` Sidong Yang
2021-08-23 9:44 ` Filipe Manana
2021-08-23 23:51 ` Sidong Yang
2021-08-26 14:08 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210820004100.35823-1-realwakka@gmail.com \
--to=realwakka@gmail.com \
--cc=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
--cc=nborisov@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).