linux-btrfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Zygo Blaxell <ce3g8jdj@umail.furryterror.org>
To: linux-btrfs@vger.kernel.org
Subject: Regression in v5.14-rc1: f2165627319f btrfs: compression: don't try to compress if we don't have enough pages
Date: Sun, 22 Aug 2021 01:51:15 -0400	[thread overview]
Message-ID: <20210822055115.GD29026@hungrycats.org> (raw)

Before this commit:

	# head /dev/zero -c 4095 > inline
	# compsize inline
	Type       Perc     Disk Usage   Uncompressed Referenced  
	TOTAL        0%       18B         3.9K         3.9K       
	zstd         0%       18B         3.9K         3.9K       

After this commit:

	# head /dev/zero -c 4095 > inline                                                                        
	# compsize inline                                                                                        
	Processed 1 file, 1 regular extents (1 refs), 0 inline.                                                                                      
	Type       Perc     Disk Usage   Uncompressed Referenced                                                                                     
	TOTAL      100%      4.0K         4.0K         4.0K                                                                                          
	none       100%      4.0K         4.0K         4.0K                                                                                          

This change makes the metadata sizes of trees of small files (e.g. source
checkouts) blow up.

It looks like we need to look at the offset of the extent, as well as
its length.

             reply	other threads:[~2021-08-22  5:52 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-22  5:51 Zygo Blaxell [this message]
2021-08-22  6:02 ` Regression in v5.14-rc1: f2165627319f btrfs: compression: don't try to compress if we don't have enough pages Zygo Blaxell
2021-08-23 11:17 ` David Sterba
2021-08-26 19:36   ` David Sterba

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210822055115.GD29026@hungrycats.org \
    --to=ce3g8jdj@umail.furryterror.org \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).