From: David Sterba <dsterba@suse.cz>
To: fdmanana@kernel.org
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 1/5] btrfs: remove root argument from btrfs_log_inode() and its callees
Date: Fri, 17 Sep 2021 12:51:58 +0200 [thread overview]
Message-ID: <20210917105158.GL9286@twin.jikos.cz> (raw)
In-Reply-To: <03c99e78af748d21af7ff0bb6e915230cf0e3310.1631787796.git.fdmanana@suse.com>
On Thu, Sep 16, 2021 at 11:32:10AM +0100, fdmanana@kernel.org wrote:
> From: Filipe Manana <fdmanana@suse.com>
>
> The root argument passed to btrfs_log_inode() is unncessary, as it is
> always the root of the inode we are going to log. This root also gets
> unnecessarily propagated to several functions called by btrfs_log_inode(),
> and all of them take the inode as an argument as well. So just remove
> the root argument from these functions and have them get the root from
> the inode where needed.
>
> This patch is part of a patchset comprised of the following 5 patches:
>
> btrfs: remove root argument from btrfs_log_inode() and its callees
> btrfs: remove redundant log root assignment from log_dir_items()
> btrfs: factor out the copying loop of dir items from log_dir_items()
> btrfs: insert items in batches when logging a directory when possible
> btrfs: keep track of the last logged keys when logging a directory
This is a nice description, in all the patches, though I think you could
make it less tedious for yourself to just reference the patch with
results or a significant change. Up to you.
next prev parent reply other threads:[~2021-09-17 10:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-16 10:32 [PATCH 0/5] btrfs: rework directory logging to make it more efficient fdmanana
2021-09-16 10:32 ` [PATCH 1/5] btrfs: remove root argument from btrfs_log_inode() and its callees fdmanana
2021-09-17 10:51 ` David Sterba [this message]
2021-09-17 11:09 ` Filipe Manana
2021-09-17 11:34 ` David Sterba
2021-09-16 10:32 ` [PATCH 2/5] btrfs: remove redundant log root assignment from log_dir_items() fdmanana
2021-09-16 10:32 ` [PATCH 3/5] btrfs: factor out the copying loop of dir items " fdmanana
2021-09-16 10:32 ` [PATCH 4/5] btrfs: insert items in batches when logging a directory when possible fdmanana
2021-09-16 10:32 ` [PATCH 5/5] btrfs: keep track of the last logged keys when logging a directory fdmanana
2021-09-17 10:46 ` [PATCH 0/5] btrfs: rework directory logging to make it more efficient David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210917105158.GL9286@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=fdmanana@kernel.org \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).