From: David Sterba <dsterba@suse.cz>
To: Nikolay Borisov <nborisov@suse.com>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] btrfs-progs: Remove support for BTRFS_SUBVOL_CREATE_ASYNC
Date: Thu, 23 Sep 2021 21:17:59 +0200 [thread overview]
Message-ID: <20210923191759.GW9286@twin.jikos.cz> (raw)
In-Reply-To: <20210923124127.119119-1-nborisov@suse.com>
On Thu, Sep 23, 2021 at 03:41:27PM +0300, Nikolay Borisov wrote:
> Kernel has removed support for this feature in 5.7 so let's remove
> support from progs as well.
>
> Signed-off-by: Nikolay Borisov <nborisov@suse.com>
> ---
>
> This has been languishing on my local branch, let's merge it and be done with
> it once for all.
>
> ioctl.h | 4 +--
> libbtrfsutil/README.md | 14 ++------
> libbtrfsutil/btrfs.h | 4 +--
> libbtrfsutil/btrfsutil.h | 23 +++++--------
> libbtrfsutil/python/module.c | 6 ++--
> libbtrfsutil/python/tests/test_subvolume.py | 12 ++-----
> libbtrfsutil/subvolume.c | 38 ++++++---------------
> 7 files changed, 29 insertions(+), 72 deletions(-)
>
> diff --git a/ioctl.h b/ioctl.h
> index 5ce47c838b0e..aad3e9772908 100644
> --- a/ioctl.h
> +++ b/ioctl.h
> @@ -49,15 +49,13 @@ BUILD_ASSERT(sizeof(struct btrfs_ioctl_vol_args) == 4096);
>
> #define BTRFS_DEVICE_PATH_NAME_MAX 1024
>
> -#define BTRFS_SUBVOL_CREATE_ASYNC (1ULL << 0)
We had the problem in kernel, fixed by 34c51814b2b87cb2e, we can't just
remove things from public interfaces.
next prev parent reply other threads:[~2021-09-23 19:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-23 12:41 [PATCH] btrfs-progs: Remove support for BTRFS_SUBVOL_CREATE_ASYNC Nikolay Borisov
2021-09-23 19:17 ` David Sterba [this message]
2021-09-24 9:25 ` David Sterba
-- strict thread matches above, loose matches on Subject: below --
2020-03-13 15:31 Nikolay Borisov
2020-03-13 18:36 ` Omar Sandoval
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210923191759.GW9286@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
--cc=nborisov@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).