From: David Sterba <dsterba@suse.cz>
To: Qu Wenruo <wqu@suse.com>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 1/2] btrfs: update SCRUB_MAX_PAGES_PER_BLOCK
Date: Mon, 6 Dec 2021 22:14:30 +0100 [thread overview]
Message-ID: <20211206211430.GV28560@twin.jikos.cz> (raw)
In-Reply-To: <20211206055258.49061-1-wqu@suse.com>
On Mon, Dec 06, 2021 at 01:52:57PM +0800, Qu Wenruo wrote:
> Use BTRFS_MAX_METADATA_BLOCKSIZE and SZ_4K (minimal sectorsize) to
> calculate this value.
>
> And remove one stale comment on the value, in fact with recent subpage
> support, BTRFS_MAX_METADATA_BLOCKSIZE * PAGE_SIZE is already beyond
> BTRFS_STRIPE_LEN, just we don't use the full page.
>
> Also since we're here, update the BUG_ON() related to
> SCRUB_MAX_PAGES_PER_BLOCK to ASSERT().
>
> As those ASSERT() are really only for developers to catch early obvious
> bugs, not to let end users suffer.
>
> Signed-off-by: Qu Wenruo <wqu@suse.com>
1 and 2 added to misc-next, thanks.
prev parent reply other threads:[~2021-12-06 21:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-06 5:52 [PATCH 1/2] btrfs: update SCRUB_MAX_PAGES_PER_BLOCK Qu Wenruo
2021-12-06 5:52 ` [PATCH 2/2] btrfs: merge SCRUB_PAGES_PER_RD_BIO and SCRUB_PAGES_PER_WR_BIO Qu Wenruo
2021-12-06 21:14 ` David Sterba [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211206211430.GV28560@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).