From: Tom Rini <trini@konsulko.com>
To: Qu Wenruo <quwenruo.btrfs@gmx.com>
Cc: Qu Wenruo <wqu@suse.com>,
u-boot@lists.denx.de, marek.behun@nic.cz,
linux-btrfs@vger.kernel.org, jnhuang95@gmail.com,
linux-erofs@lists.ozlabs.org, joaomarcos.costa@bootlin.com,
thomas.petazzoni@bootlin.com, miquel.raynal@bootlin.com
Subject: Re: [PATCH 1/8] fs: fat: unexport file_fat_read_at()
Date: Mon, 25 Jul 2022 22:12:35 -0400 [thread overview]
Message-ID: <20220726021235.GI1146598@bill-the-cat> (raw)
In-Reply-To: <6271e1a2-db85-fb20-6ea8-d23afcb6bc69@gmx.com>
[-- Attachment #1: Type: text/plain, Size: 774 bytes --]
On Tue, Jul 26, 2022 at 09:35:51AM +0800, Qu Wenruo wrote:
>
>
> On 2022/7/26 06:28, Tom Rini wrote:
> > On Wed, Jun 29, 2022 at 07:38:22PM +0800, Qu Wenruo wrote:
> >
> > > That function is only utilized inside fat driver, unexport it.
> > >
> > > Signed-off-by: Qu Wenruo <wqu@suse.com>
> >
> > The series has a fails to build on nokia_rx51:
> > https://source.denx.de/u-boot/u-boot/-/jobs/471877#L483
> > which to me says doing 64bit division (likely related to block size,
> > etc) without using the appropriate helper macros to turn them in to bit
> > shifts instead.
> >
> Should I update and resend the series or just send the incremental
> update to fix the U64/U32 division?
Please rebase and resend the whole series, thanks.
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
next prev parent reply other threads:[~2022-07-26 2:12 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-29 11:38 [PATCH 0/8] U-boot: fs: add generic unaligned read offset handling Qu Wenruo
2022-06-29 11:38 ` [PATCH 1/8] fs: fat: unexport file_fat_read_at() Qu Wenruo
2022-07-25 22:28 ` Tom Rini
2022-07-26 1:35 ` Qu Wenruo
2022-07-26 2:12 ` Tom Rini [this message]
2022-06-29 11:38 ` [PATCH 2/8] fs: btrfs: fix a bug which no data get read if the length is not 0 Qu Wenruo
2022-06-29 11:38 ` [PATCH 3/8] fs: btrfs: fix a crash if specified range is beyond file size Qu Wenruo
2022-06-29 11:38 ` [PATCH 4/8] fs: btrfs: move the unaligned read code to _fs_read() for btrfs Qu Wenruo
2022-06-29 11:38 ` [PATCH 5/8] fs: ext4: rely on _fs_read() to handle leading unaligned block read Qu Wenruo
2022-06-29 11:38 ` [PATCH 6/8] fs: fat: rely on higher layer to get block aligned read range Qu Wenruo
2022-06-29 11:38 ` [PATCH 7/8] fs: ubifs: rely on higher layer to do unaligned read Qu Wenruo
2022-06-29 11:38 ` [PATCH 8/8] fs: erofs: add unaligned read range handling Qu Wenruo
2022-06-30 12:21 ` Huang Jianan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220726021235.GI1146598@bill-the-cat \
--to=trini@konsulko.com \
--cc=jnhuang95@gmail.com \
--cc=joaomarcos.costa@bootlin.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-erofs@lists.ozlabs.org \
--cc=marek.behun@nic.cz \
--cc=miquel.raynal@bootlin.com \
--cc=quwenruo.btrfs@gmx.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=u-boot@lists.denx.de \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).