linux-btrfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Sterba <dsterba@suse.cz>
To: Chris Murphy <lists@colorremedies.com>
Cc: Neal Gompa <ngompa13@gmail.com>,
	Btrfs BTRFS <linux-btrfs@vger.kernel.org>,
	Chris Mason <clm@fb.com>, Josef Bacik <josef@toxicpanda.com>
Subject: Re: Using async discard by default with SSDs?
Date: Wed, 27 Jul 2022 19:47:26 +0200	[thread overview]
Message-ID: <20220727174726.GU13489@suse.cz> (raw)
In-Reply-To: <f14ed453-390b-4537-8a8c-0600e08d4278@www.fastmail.com>

On Wed, Jul 27, 2022 at 11:14:01AM -0400, Chris Murphy wrote:
> 
> 
> On Wed, Jul 27, 2022, at 10:56 AM, David Sterba wrote:
> > On Wed, Jul 27, 2022 at 10:50:01AM -0400, Chris Murphy wrote:
> >> What is a likely target kernel version to make discard=async the
> >> default? The merge window for 5.20 closes August 14. Is 5.21 a
> >> practical target?
> >
> > The changes for the next merge window are supposed to be done a week or
> > two before it opens, but as this is a simple change I think I can
> > squeeze it in.
> 
> For 5.20?

Yes, 5.20.

> I'm not aware of any conflict with fstrim. But I wonder if there's a
> preference to coordinate the change with util-linux folks? 

The -o discard and fstrim are independent and can be used at the same
time.

> Currently, util-linux provides fstrim.timer which runs fstrim.service every Monday at 00:00 local time. The command is:
> 
> ExecStart=/usr/sbin/fstrim --listed-in /etc/fstab:/proc/self/mountinfo --verbose --quiet-unsupported
> 
> I'm not sure how they'd go about implementing an exception for Btrfs,
> either entirely or only if a discard mount option is detected. But I
> can ask?

No need for an exception, during mount btrfs track ranges that have been
trimmed and skips them when discard is requested by fstrim, so it's a
no-op.

  reply	other threads:[~2022-07-27 18:54 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-21 18:43 Using async discard by default with SSDs? Neal Gompa
2022-07-21 19:21 ` Roman Mamedov
2022-07-25 19:08 ` David Sterba
2022-07-26 20:00   ` Chris Murphy
2022-07-26 21:36     ` David Sterba
2022-07-26 22:10       ` Chris Murphy
2022-07-27 14:50         ` Chris Murphy
2022-07-27 14:56           ` David Sterba
2022-07-27 15:14             ` Chris Murphy
2022-07-27 17:47               ` David Sterba [this message]
2022-07-28 12:27                 ` Chris Murphy
2022-07-27 15:26             ` Neal Gompa
2022-08-05 15:14             ` David Sterba

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220727174726.GU13489@suse.cz \
    --to=dsterba@suse.cz \
    --cc=clm@fb.com \
    --cc=josef@toxicpanda.com \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=lists@colorremedies.com \
    --cc=ngompa13@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).