linux-btrfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Sterba <dsterba@suse.cz>
To: Christoph Hellwig <hch@lst.de>
Cc: Johannes Thumshirn <Johannes.Thumshirn@wdc.com>,
	Chris Mason <clm@fb.com>, Josef Bacik <josef@toxicpanda.com>,
	David Sterba <dsterba@suse.com>, Qu Wenruo <wqu@suse.com>,
	"linux-btrfs@vger.kernel.org" <linux-btrfs@vger.kernel.org>
Subject: Re: [PATCH 1/2] btrfs: split the bio submission path into a separate file
Date: Wed, 21 Sep 2022 11:40:14 +0200	[thread overview]
Message-ID: <20220921094014.GB32411@twin.jikos.cz> (raw)
In-Reply-To: <20220913050829.GA29304@lst.de>

On Tue, Sep 13, 2022 at 07:08:29AM +0200, Christoph Hellwig wrote:
> On Mon, Sep 12, 2022 at 03:27:10PM +0000, Johannes Thumshirn wrote:
> > On 12.09.22 16:11, Christoph Hellwig wrote:
> > > +// SPDX-License-Identifier: GPL-2.0
> > > +/*
> > > + * Copyright (C) 2007 Oracle.  All rights reserved.
> > > + * Copyright (C) 2022 Christoph Hellwig.
> > > + */
> > 
> > IIRC David does try to get rid of all the per-company copyright
> > statements for new files.
> 
> We just had that discussion in another thread - there really is no
> basis for getting rid of them.  In fact talking to lawyers, most
> of them thing we should have more of them, not less.

There seems to be no clear consensus that would satisfy lawyers (track
complete copyright information) and practical point of view (it's in the
git metadata). The problem not only I see taking this patch as an
example is that your (c) name now appears in file containing changes
from several other people whose names are not mentioned (but yes the
original copyright is preserved).

I don't want to speculate what would this mean from the legal POV and I
think we've heard each other's arguments. If there's a recommended
practice coming "from above" as linux project, like it was with the
SPDX, ok let everybody add their copyright notices. But until then I
won't take such patches.

  reply	other threads:[~2022-09-21  9:49 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-12 14:11 move the low-level btrfs_bio code into a separate file (resent) Christoph Hellwig
2022-09-12 14:11 ` [PATCH 1/2] btrfs: split the bio submission path into a separate file Christoph Hellwig
2022-09-12 15:27   ` Johannes Thumshirn
2022-09-13  5:08     ` Christoph Hellwig
2022-09-21  9:40       ` David Sterba [this message]
2022-09-22  6:39         ` Christoph Hellwig
2022-09-12 14:11 ` [PATCH 2/2] btrfs: move repair_io_failure to bio.c Christoph Hellwig
2022-09-12 15:28   ` Johannes Thumshirn
2022-09-12 18:02 ` move the low-level btrfs_bio code into a separate file (resent) Josef Bacik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220921094014.GB32411@twin.jikos.cz \
    --to=dsterba@suse.cz \
    --cc=Johannes.Thumshirn@wdc.com \
    --cc=clm@fb.com \
    --cc=dsterba@suse.com \
    --cc=hch@lst.de \
    --cc=josef@toxicpanda.com \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=wqu@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).