linux-btrfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Sterba <dsterba@suse.cz>
To: Qu Wenruo <quwenruo.btrfs@gmx.com>
Cc: dsterba@suse.cz, Neal Gompa <ngompa@fedoraproject.org>,
	Btrfs BTRFS <linux-btrfs@vger.kernel.org>,
	Josef Bacik <josef@toxicpanda.com>, Qu Wenruo <wqu@suse.com>
Subject: Re: btrfs-progs 6.1 broke the build for multiple applications
Date: Tue, 3 Jan 2023 13:06:40 +0100	[thread overview]
Message-ID: <20230103120640.GO11562@twin.jikos.cz> (raw)
In-Reply-To: <22447f37-50fa-3914-a817-e95b66797944@gmx.com>

On Tue, Jan 03, 2023 at 08:02:27PM +0800, Qu Wenruo wrote:
> 
> 
> On 2023/1/3 19:39, David Sterba wrote:
> > On Mon, Jan 02, 2023 at 07:11:57PM -0500, Neal Gompa wrote:
> >> Hey all,
> >>
> >> It looks like btrfs-progs v6.1 broke the build for multiple
> >> applications in Fedora.
> >>
> >> Notably, it broke:
> >>
> >> * btrfs-assistant
> >> * buildah
> >> * cri-o
> >> * podman
> >> * skopeo
> >> * containerd
> >> * moby/docker
> >> * snapper
> >> * source-to-image
> >>
> >> The bug report is here: https://bugzilla.redhat.com/2157606
> >>
> >> It looks like this change broke everything:
> >> https://github.com/kdave/btrfs-progs/commit/03451430de7cd2fad18b0f01745545758bc975a5
> > 
> > On no that's bad, I'm going to do a bugfix release today.
> 
> I'm a little confused, why would those projects relying on the ioctl.h 
> from progs?

Because they're probably using the legacy libbtrfs and headers from
/usr/bin/btrfs/*.h, it'll take time before all could be switched to
libbtrfsutil.

> Shouldn't those things got exported through kernel uapi?

The kernel UAPI reflects what the installed and possibly running kernel
API is providing, interfaces that can be used at run time. But the build
can be against any newer version even with functionality not implemented
by the kernel. Think LTS stable releases vs updated btrfs-progs.

  reply	other threads:[~2023-01-03 12:12 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-03  0:11 btrfs-progs 6.1 broke the build for multiple applications Neal Gompa
2023-01-03 11:39 ` David Sterba
2023-01-03 12:02   ` Qu Wenruo
2023-01-03 12:06     ` David Sterba [this message]
2023-01-03 18:00       ` Bjorn Neergaard
2023-01-04 17:23         ` Bjorn Neergaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230103120640.GO11562@twin.jikos.cz \
    --to=dsterba@suse.cz \
    --cc=josef@toxicpanda.com \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=ngompa@fedoraproject.org \
    --cc=quwenruo.btrfs@gmx.com \
    --cc=wqu@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).