From: David Sterba <dsterba@suse.cz>
To: robbieko <robbieko@synology.com>
Cc: David Sterba <dsterba@suse.cz>,
Josef Bacik <josef@toxicpanda.com>,
linux-btrfs@vger.kernel.org
Subject: Re: [PATCH v2 0/3] btrfs: fix unexpected -ENOMEM with percpu_counter_init when create snapshot
Date: Thu, 9 Mar 2023 19:47:41 +0100 [thread overview]
Message-ID: <20230309184741.GN10580@twin.jikos.cz> (raw)
In-Reply-To: <20230110150818.GD11562@twin.jikos.cz>
On Tue, Jan 10, 2023 at 04:08:18PM +0100, David Sterba wrote:
> > Sorry for the late reply, I've been busy recently.
> > This modification will not affect the original btrfs_drew_lock behavior,
> > and the framework can also provide future scenarios where memory
> > needs to be allocated in init_fs_root.
>
> With the conversion to atomic_t the preallocation can remain unchanged
> as there would be only the anon bdev preallocated, then there's not much
> reason to have the infrastructure.
>
> I'm now testing the patch below, it's relatively short an can be
> backported if needed but it can potentially make the performance worse
> in some cases.
I forgot to CC you, the patch implementing the switch to atomic has been
sent and merged to misc-next.
https://lore.kernel.org/linux-btrfs/20230301204708.25710-1-dsterba@suse.com/
next prev parent reply other threads:[~2023-03-09 18:54 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-14 2:11 [PATCH v2 0/3] btrfs: fix unexpected -ENOMEM with percpu_counter_init when create snapshot robbieko
2022-12-14 2:11 ` [PATCH v2 1/3] btrfs: refactor anon_dev with new_fs_root_args for create subvolume/snapshot robbieko
2022-12-14 2:11 ` [PATCH v2 2/3] btrfs: change snapshot_lock to dynamic pointer robbieko
2022-12-14 2:11 ` [PATCH v2 3/3] btrfs: add snapshot_lock to new_fs_root_args robbieko
2022-12-14 16:59 ` [PATCH v2 0/3] btrfs: fix unexpected -ENOMEM with percpu_counter_init when create snapshot Josef Bacik
2022-12-14 18:07 ` David Sterba
2022-12-19 6:54 ` robbieko
2023-01-10 15:08 ` David Sterba
2023-03-09 18:47 ` David Sterba [this message]
2023-03-10 1:07 ` robbieko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230309184741.GN10580@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=josef@toxicpanda.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=robbieko@synology.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).