From: David Sterba <dsterba@suse.cz>
To: Boris Burkov <boris@bur.io>
Cc: David Sterba <dsterba@suse.cz>,
linux-btrfs@vger.kernel.org, kernel-team@fb.com
Subject: Re: [PATCH v3] btrfs: fix dio continue after short write due to buffer page fault
Date: Wed, 15 Mar 2023 20:52:31 +0100 [thread overview]
Message-ID: <20230315195231.GW10580@twin.jikos.cz> (raw)
In-Reply-To: <20230315195255.GA27662@zen>
On Wed, Mar 15, 2023 at 12:53:24PM -0700, Boris Burkov wrote:
> On Thu, Mar 09, 2023 at 06:40:50PM +0100, David Sterba wrote:
> > On Tue, Mar 07, 2023 at 12:49:30PM -0800, Boris Burkov wrote:
> > > Link: https://bugzilla.redhat.com/show_bug.cgi?id=2169947
> > > Link: https://lore.kernel.org/linux-btrfs/aa1fb69e-b613-47aa-a99e-a0a2c9ed273f@app.fastmail.com/
> > > Link: https://pastebin.com/3SDaH8C6
> > > Reviewed-by: Filipe Manana <fdmanana@suse.com>
> > > Reviewed-by: Christoph Hellwig <hch@lst.de>
> > > Signed-off-by: Boris Burkov <boris@bur.io>
> > > Signed-off-by: David Sterba <dsterba@suse.com>
> > > ---
> > > Changelog:
> > > v3:
> > > - handle BTRFS_IOERR set on the ordered_extent in btrfs_dio_iomap_end.
> > > If the bio fails before we loop in the submission loop and exit from
> > > the loop early, we never submit a second bio covering the rest of the
> > > extent range, resulting in leaking the ordered_extent, which hangs umount.
> > > We can distinguish this from a short write in btrfs_dio_iomap_end by
> > > checking the ordered_extent.
> >
> > Replaced v2 in misc-next, thanks.
>
> Embarassingly, I have now proven that this version is _still_ broken :(
>
> TL;DR, this "fix" reintroduces the original bug Filipe was fixing in the
> first place, just a more subtle version of it.
Ok thanks, I'll remove the patch from branches.
prev parent reply other threads:[~2023-03-15 19:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-07 20:49 [PATCH v3] btrfs: fix dio continue after short write due to buffer page fault Boris Burkov
2023-03-08 16:00 ` Sweet Tea Dorminy
2023-03-09 17:40 ` David Sterba
2023-03-15 19:53 ` Boris Burkov
2023-03-15 19:52 ` David Sterba [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230315195231.GW10580@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=boris@bur.io \
--cc=kernel-team@fb.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).