From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 06B7E12AACC for ; Wed, 24 Jan 2024 19:52:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=66.111.4.25 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706125955; cv=none; b=hODyp86ekXj0zlgNPI4H3NY6+nA+iG/oZdbLnIDClubicNCgbfKXVCDNbZnNiwh7idU4gth7uunkeyGMVRy4B7/DpBzWgUDgO8db1RuiMKgb5EkUQeDNd63UXuimWcSqGgKkq4jzCDk1rjJGlXZUtteX5vZ3w1E0nfoHKSnEjRk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706125955; c=relaxed/simple; bh=XAPNVKtoTXZ6if8vHQ+KJl2nRxz/yXhwn1jds7fakj0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=iPDuFyiPQiOhQOF04CDjz5RXUUvi4gNK7clsGya0Fy5Nw57wOQxblLJd5H+LqV1qAJq9gSmiF8oKReHyzduGu25yskjLzyfVq2HNUHPYuBboeEQGVpfZcejGJWE7A1e7hYT0qKWK+tylhFgW4i4ntrnCoSjKO8rI+FeMd4ricGQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bur.io; spf=pass smtp.mailfrom=bur.io; dkim=pass (2048-bit key) header.d=bur.io header.i=@bur.io header.b=MUkoEm1T; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b=m2mWa6YQ; arc=none smtp.client-ip=66.111.4.25 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bur.io Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bur.io Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bur.io header.i=@bur.io header.b="MUkoEm1T"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="m2mWa6YQ" Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 1119E5C012D; Wed, 24 Jan 2024 14:52:33 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Wed, 24 Jan 2024 14:52:33 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bur.io; h=cc:cc :content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm1; t=1706125953; x=1706212353; bh=81KK0SShQq YKzrVPEJNT87pZtNejjrZZ5pll0ggDP9M=; b=MUkoEm1TNGc7t/klo2Pk9q2xze 1L8rh6PPcVgrbP/2i9SPLChHsorYoiyOAZxPNa3thL68Zyl5D7PxVLtdagMilonr tYG5cLn7+UgiIgjWZCU08K4yxEPKiwewyE6hrnuXwJrZj+aw/6+cS0RjOgFdYjrU eQhMCuDZ/KFpHUhF7R8ptm66XCfomo1j61G5XYFKXd0a7j3zUh7ecCdfdUGNdD7x iVsjlznW5jVWvqjLEjQzNtJal+An3tzdOWj+nNxu4llkqkTz1hTWPMcCvwpq3YVx 0csSYIUvFqj3KbMtVqch0JJn/3VAAdUSDC6mIyHm2S53PgQGdqQu/MGAP3Ww== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; t=1706125953; x=1706212353; bh=81KK0SShQqYKzrVPEJNT87pZtNej jrZZ5pll0ggDP9M=; b=m2mWa6YQrmU8JgTsNRM5Q3n2k4a87epmX3D1jGEgmv33 5T3m+xQt6W4kU9NPR6nYBtJ+AkUS8mykcbj04gzmDnl+YeWhXPNd6ojw/mp3CG6o mzfN+rIh2RY4UH4poHc9c8c/Nct1uSdMtCFtBfambPJZRSMwzDcDT98Ne92zTFGA 2FqKxg1mauONFLPM4m4AcH3nh+XAYiIY5+k8FjlhCQr3uOMpL7nKNZEm4X0riGAq uSpxpKn7Za8Lv0A3THX0TTDswHc67EkNXRQPswL89tNXYXf8Vq4TBXHpdKdbSG/5 GBYViZp0Z2/KZNlgr0DkWfFJZmY6dmepRKggJpOhQw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrvdeluddguddvjecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpeffhffvvefukfhfgggtuggjsehttdertddttddvnecuhfhrohhmpeeuohhr ihhsuceuuhhrkhhovhcuoegsohhrihhssegsuhhrrdhioheqnecuggftrfgrthhtvghrnh epkedvkeffjeellefhveehvdejudfhjedthfdvveeiieeiudfguefgtdejgfefleejnecu vehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepsghorhhish essghurhdrihho X-ME-Proxy: Feedback-ID: i083147f8:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 24 Jan 2024 14:52:32 -0500 (EST) Date: Wed, 24 Jan 2024 11:53:34 -0800 From: Boris Burkov To: Josef Bacik Cc: linux-btrfs@vger.kernel.org, kernel-team@fb.com, Sweet Tea Dorminy Subject: Re: [PATCH v5 11/52] btrfs: disable verity on encrypted inodes Message-ID: <20240124195334.GD1789919@zen.localdomain> References: Precedence: bulk X-Mailing-List: linux-btrfs@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Wed, Jan 24, 2024 at 12:18:33PM -0500, Josef Bacik wrote: > From: Sweet Tea Dorminy > > Right now there isn't a way to encrypt things that aren't either > filenames in directories or data on blocks on disk with extent > encryption, so for now, disable verity usage with encryption on btrfs. > > Signed-off-by: Sweet Tea Dorminy > Signed-off-by: Josef Bacik Reviewed-by: Boris Burkov > --- > fs/btrfs/verity.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/fs/btrfs/verity.c b/fs/btrfs/verity.c > index 66e2270b0dae..352b2644b4af 100644 > --- a/fs/btrfs/verity.c > +++ b/fs/btrfs/verity.c > @@ -588,6 +588,9 @@ static int btrfs_begin_enable_verity(struct file *filp) > > ASSERT(inode_is_locked(file_inode(filp))); > > + if (IS_ENCRYPTED(&inode->vfs_inode)) > + return -EOPNOTSUPP; > + > if (test_bit(BTRFS_INODE_VERITY_IN_PROGRESS, &inode->runtime_flags)) > return -EBUSY; > > -- > 2.43.0 >