Re: [PATCH] btrfs-progs: check: Fix error reporting on root inode

[Josef Bacik <josef@toxicpanda.com>]

On 8/24/20 10:00 AM, Nikolay Borisov wrote:
> If btrfs check detects an error on the root inode of a subvolume it
> prints:
> 
>      Opening filesystem to check...
>      Checking filesystem on /dev/vdc
>      UUID: 4ac7a216-bf97-4c5f-9899-0f203c20d8af
>      [1/7] checking root items
>      [2/7] checking extents
>      [3/7] checking free space cache
>      [4/7] checking fs roots
>      root 5 root dir 256 error
>      ERROR: errors found in fs roots
>      found 196608 bytes used, error(s) found
>      total csum bytes: 0
>      total tree bytes: 131072
>      total fs tree bytes: 32768
>      total extent tree bytes: 16384
>      btree space waste bytes: 124376
>      file data blocks allocated: 65536
>       referenced 65536
> 
> This is not very helpful since there is no specific information about
> the exact error. This is due to the fact that check_root_dir doesn't
> set inode_record::errors accordingly. This patch rectifies this and now
> the output would look like:
> 
> 	[1/7] checking root items
> 	[2/7] checking extents
> 	[3/7] checking free space cache
> 	[4/7] checking fs roots
> 	root 5 inode 256 errors 2000, link count wrong
> 	ERROR: errors found in fs roots
> 	found 196608 bytes used, error(s) found
> 	total csum bytes: 0
> 	total tree bytes: 131072
> 	total fs tree bytes: 32768
> 	total extent tree bytes: 16384
> 	btree space waste bytes: 124376
> 	file data blocks allocated: 65536
> 	 referenced 65536
> 
> Signed-off-by: Nikolay Borisov <nborisov@suse.com>

Reviewed-by: Josef Bacik <josef@toxicpanda.com>

Thanks,

Josef