From: Nikolay Borisov <nborisov@suse.com>
To: Anand Jain <anand.jain@oracle.com>, linux-btrfs@vger.kernel.org
Cc: calestyo@scientia.net
Subject: Re: [PATCH] btrfs: fix warn_on for send from readonly mount
Date: Mon, 2 Dec 2019 11:48:18 +0200 [thread overview]
Message-ID: <230b4962-a39b-8ef0-d2c1-12df2c860b1a@suse.com> (raw)
In-Reply-To: <20191202094450.1377-1-anand.jain@oracle.com>
On 2.12.19 г. 11:44 ч., Anand Jain wrote:
> We log warning if root::orphan_cleanup_state is not set to
> ORPHAN_CLEANUP_DONE in btrfs_ioctl_send(). However if the filesystem is
> mounted as readonly we skip the orphan items cleanup during the lookup
> and root::orphan_cleanup_state remains at the init state 0 instead of
> ORPHAN_CLEANUP_DONE (2).
>
> WARNING: CPU: 0 PID: 2616 at /Volumes/ws/btrfs-devel/fs/btrfs/send.c:7090 btrfs_ioctl_send+0xb2f/0x18c0 [btrfs]
> ::
> RIP: 0010:btrfs_ioctl_send+0xb2f/0x18c0 [btrfs]
> ::
> Call Trace:
> ::
> _btrfs_ioctl_send+0x7b/0x110 [btrfs]
> btrfs_ioctl+0x150a/0x2b00 [btrfs]
> ::
> do_vfs_ioctl+0xa9/0x620
> ? __fget+0xac/0xe0
> ksys_ioctl+0x60/0x90
> __x64_sys_ioctl+0x16/0x20
> do_syscall_64+0x49/0x130
> entry_SYSCALL_64_after_hwframe+0x44/0xa9
>
> Reproducer:
> mkfs.btrfs -fq /dev/sdb && mount /dev/sdb /btrfs
> btrfs subvolume create /btrfs/sv1
> btrfs subvolume snapshot -r /btrfs/sv1 /btrfs/ss1
> umount /btrfs && mount -o ro /dev/sdb /btrfs
> btrfs send /btrfs/ss1 -f /tmp/f
>
> Fix this by checking for the expected ORPHAN_CLEANUP_DONE only if the
> filesystem is in writable state.
>
> Reported-by: Christoph Anton Mitterer <calestyo@scientia.net>
> Signed-off-by: Anand Jain <anand.jain@oracle.com>
> ---
> fs/btrfs/send.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/fs/btrfs/send.c b/fs/btrfs/send.c
> index ae2db5eb1549..e3acec8aa8de 100644
> --- a/fs/btrfs/send.c
> +++ b/fs/btrfs/send.c
> @@ -7085,9 +7085,11 @@ long btrfs_ioctl_send(struct file *mnt_file, struct btrfs_ioctl_send_args *arg)
>
> /*
> * This is done when we lookup the root, it should already be complete
> - * by the time we get here.
> + * by the time we get here, unless the filesystem is readonly where the
> + * orphan_cleanup_state is never started.
> */
> - WARN_ON(send_root->orphan_cleanup_state != ORPHAN_CLEANUP_DONE);
> + if (!sb_rdonly(file_inode(mnt_file)->i_sb))
> + WARN_ON(send_root->orphan_cleanup_state != ORPHAN_CLEANUP_DONE);
nit: WARN_ON(!sb_rdonly() && send_root->orphan_cleanup_state != ORPHAN_CLEANUP_DONE) ?
>
> /*
> * Userspace tools do the checks and warn the user if it's
>
next prev parent reply other threads:[~2019-12-02 9:48 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-02 9:44 [PATCH] btrfs: fix warn_on for send from readonly mount Anand Jain
2019-12-02 9:48 ` Nikolay Borisov [this message]
2019-12-02 11:23 ` Filipe Manana
2019-12-02 14:07 ` Anand Jain
2019-12-02 14:24 ` [PATCH v2] " Anand Jain
2019-12-02 15:42 ` Filipe Manana
2019-12-02 23:59 ` Anand Jain
2019-12-03 11:45 ` Filipe Manana
2019-12-05 11:39 ` [PATCH v3] " Anand Jain
2019-12-05 11:43 ` Filipe Manana
2019-12-05 11:45 ` Anand Jain
2019-12-10 16:51 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=230b4962-a39b-8ef0-d2c1-12df2c860b1a@suse.com \
--to=nborisov@suse.com \
--cc=anand.jain@oracle.com \
--cc=calestyo@scientia.net \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).