From: WenRuo Qu <wqu@suse.com>
To: Anand Jain <anand.jain@oracle.com>,
"linux-btrfs@vger.kernel.org" <linux-btrfs@vger.kernel.org>
Subject: Re: [PATCH] btrfs: volumes: Allow missing devices to be writeable
Date: Thu, 12 Sep 2019 10:32:09 +0000 [thread overview]
Message-ID: <25e93ff4-6252-1e39-f60a-89134129c00d@suse.com> (raw)
In-Reply-To: <7e9294de-1859-886a-3ac3-9659e70463d7@oracle.com>
On 2019/9/12 下午6:27, Anand Jain wrote:
>
>
> There is previous work [1]
>
> [1]
> https://lore.kernel.org/linux-btrfs/1461812780-538-1-git-send-email-anand.jain@oracle.com/
>
>
>
> I guess it was on purpose that missing device is not part of
> alloc chunk, so to have lesser impact due to writehole bug.
> My target is to fix the writehole first, and then this and
> other bugs.
>
>> [FIX]
>> Just consider the missing devices as WRITABLE, so we allocate new chunks
>> on them to maintain old profiles.
>
> IMO. In a 3-disks raid1 when one of the disk fails, we still
> need the _new writes_ not to be degraded. Just use two available
> disks. This fix fails that idea which is being followed now.
So priority comes, use existing, and only when it's impossible, consider
degraded/missing device?
>
> Thanks, Anand
>
prev parent reply other threads:[~2019-09-12 10:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-29 7:17 [PATCH] btrfs: volumes: Allow missing devices to be writeable Qu Wenruo
2019-09-11 17:17 ` David Sterba
2019-09-11 23:39 ` Qu Wenruo
2019-09-12 10:27 ` Anand Jain
2019-09-12 10:32 ` WenRuo Qu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=25e93ff4-6252-1e39-f60a-89134129c00d@suse.com \
--to=wqu@suse.com \
--cc=anand.jain@oracle.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).