From: Nikolay Borisov <nborisov@suse.com>
To: Qu Wenruo <quwenruo.btrfs@gmx.com>,
"linux-btrfs@vger.kernel.org" <linux-btrfs@vger.kernel.org>
Subject: Re: Mixed inline and regular extents caused by btrfs/062
Date: Tue, 10 Aug 2021 10:46:41 +0300 [thread overview]
Message-ID: <2da42f71-b95d-4fb1-be93-be9e58eb1200@suse.com> (raw)
In-Reply-To: <db939df7-412d-aaef-c044-62fd2d8b2e7b@gmx.com>
On 10.08.21 г. 8:49, Qu Wenruo wrote:
> Hi,
>
> Although I understand current kernel can handle mixed inline extent with
> regular extent without problem, but the idea of mixing them is still
> making me quite unease.
>
> Thus I still go testing with modify btrfs-progs to detect such problem,
> and find out btrfs/062 can cause such mixed extents.
>
> Since it's not really causing any on-disk data corruption, but just an
> inconsistent behavior, I'm wondering do we really need to fix it.
> (This is also the only reason why subpage has disabled inline extent
> creation completely, just to prevent such problem).
>
> Any idea on whether we should "fix" the behavior?
What do you mean by mixed inline and regular extents? AFAICS inline
extents are created when you write at the beginning of the file and the
size of the write is less than the inline extent threshold? All
subsequent writes are going to be regular extents.
>
> Thanks,
> Qu
>
next prev parent reply other threads:[~2021-08-10 7:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-10 5:49 Mixed inline and regular extents caused by btrfs/062 Qu Wenruo
2021-08-10 7:46 ` Nikolay Borisov [this message]
2021-08-10 8:09 ` Qu Wenruo
2021-08-10 8:58 ` Qu Wenruo
2021-08-23 14:43 ` Filipe Manana
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2da42f71-b95d-4fb1-be93-be9e58eb1200@suse.com \
--to=nborisov@suse.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=quwenruo.btrfs@gmx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).