From: Johannes Thumshirn <johannes.thumshirn@wdc.com>
To: David Sterba <dsterba@suse.com>
Cc: Johannes Thumshirn <johannes.thumshirn@wdc.com>,
linux-btrfs@vger.kernel.org, Naohiro Aota <naohiro.aota@wdc.com>
Subject: [PATCH] btrfs: zoned: free zone_cache when freeing zone_info
Date: Fri, 3 Dec 2021 03:12:27 -0800 [thread overview]
Message-ID: <2dbe65bc10716401b0c663b1a14131becff484dd.1638529933.git.johannes.thumshirn@wdc.com> (raw)
Kmemleak was reporting the following memory leak on fstests btrfs/224 on my
zoned test setup:
unreferenced object 0xffffc900001a9000 (size 4096):
comm "mount", pid 1781, jiffies 4295339102 (age 5.740s)
hex dump (first 32 bytes):
00 00 00 00 00 00 00 00 00 00 08 00 00 00 00 00 ................
00 00 08 00 00 00 00 00 01 00 00 00 00 00 00 00 ................
backtrace:
[<00000000b0ef6261>] __vmalloc_node_range+0x240/0x3d0
[<00000000aa06ac88>] vzalloc+0x3c/0x50
[<000000001824c35c>] btrfs_get_dev_zone_info+0x426/0x7e0 [btrfs]
[<0000000004ba8d9d>] btrfs_get_dev_zone_info_all_devices+0x52/0x80 [btrfs]
[<0000000054bc27eb>] open_ctree+0x1022/0x1709 [btrfs]
[<0000000074fe7dc0>] btrfs_mount_root.cold+0x13/0xe5 [btrfs]
[<00000000a54ca18b>] legacy_get_tree+0x22/0x40
[<00000000ce480896>] vfs_get_tree+0x1b/0x80
[<000000006423c6bd>] vfs_kern_mount.part.0+0x6c/0xa0
[<000000003cf6fc28>] btrfs_mount+0x10d/0x380 [btrfs]
[<00000000a54ca18b>] legacy_get_tree+0x22/0x40
[<00000000ce480896>] vfs_get_tree+0x1b/0x80
[<00000000995da674>] path_mount+0x6b6/0xa10
[<00000000a5b4b6ec>] __x64_sys_mount+0xde/0x110
[<00000000fe985c23>] do_syscall_64+0x43/0x90
[<00000000c6071ff4>] entry_SYSCALL_64_after_hwframe+0x44/0xae
The allocated object in question is the zone_cache.
Free it when freeing a btrfs_device's zone_info.
Cc: Naohiro Aota <naohiro.aota@wdc.com>
Signed-off-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
---
fs/btrfs/zoned.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/fs/btrfs/zoned.c b/fs/btrfs/zoned.c
index c917867a4261..fc9c6ae7bc00 100644
--- a/fs/btrfs/zoned.c
+++ b/fs/btrfs/zoned.c
@@ -612,6 +612,7 @@ void btrfs_destroy_dev_zone_info(struct btrfs_device *device)
bitmap_free(zone_info->active_zones);
bitmap_free(zone_info->seq_zones);
bitmap_free(zone_info->empty_zones);
+ vfree(zone_info->zone_cache);
kfree(zone_info);
device->zone_info = NULL;
}
--
2.31.1
next reply other threads:[~2021-12-03 11:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-03 11:12 Johannes Thumshirn [this message]
2021-12-06 4:33 ` [PATCH] btrfs: zoned: free zone_cache when freeing zone_info Naohiro Aota
2021-12-06 17:00 ` David Sterba
2021-12-06 17:32 ` Johannes Thumshirn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2dbe65bc10716401b0c663b1a14131becff484dd.1638529933.git.johannes.thumshirn@wdc.com \
--to=johannes.thumshirn@wdc.com \
--cc=dsterba@suse.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=naohiro.aota@wdc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).