From: Anand Jain <anand.jain@oracle.com>
To: Colin King <colin.king@canonical.com>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH][next] btrfs: fix memory leak of path on error return path
Date: Wed, 3 Jul 2019 12:16:50 +0800 [thread overview]
Message-ID: <2e750263-c61a-cda4-a647-f1913b548c33@oracle.com> (raw)
In-Reply-To: <20190702141028.11566-1-colin.king@canonical.com>
On 2/7/19 10:10 PM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Currently if the allocation of roots or tmp_ulist fails the error handling
> does not free up the allocation of path causing a memory leak. Fix this by
> freeing path with a call to btrfs_free_path before taking the error return
> path.
>
> Addresses-Coverity: ("Resource leak")
> Fixes: 5911c8fe05c5 ("btrfs: fiemap: preallocate ulists for btrfs_check_shared")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Anand Jain <anand.jain@oracle.com>
> ---
> fs/btrfs/extent_io.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/fs/btrfs/extent_io.c b/fs/btrfs/extent_io.c
> index 1eb671c16ff1..d7f37a33d597 100644
> --- a/fs/btrfs/extent_io.c
> +++ b/fs/btrfs/extent_io.c
> @@ -4600,6 +4600,7 @@ int extent_fiemap(struct inode *inode, struct fiemap_extent_info *fieinfo,
> tmp_ulist = ulist_alloc(GFP_KERNEL);
> if (!roots || !tmp_ulist) {
> ret = -ENOMEM;
> + btrfs_free_path(path);
> goto out_free_ulist;
> }
>
>
next prev parent reply other threads:[~2019-07-03 4:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-02 14:10 [PATCH][next] btrfs: fix memory leak of path on error return path Colin King
2019-07-03 4:16 ` Anand Jain [this message]
2019-07-04 16:37 ` David Sterba
2019-07-04 16:47 ` Colin Ian King
2019-07-04 17:20 ` David Sterba
2019-07-05 1:28 ` Anand Jain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2e750263-c61a-cda4-a647-f1913b548c33@oracle.com \
--to=anand.jain@oracle.com \
--cc=colin.king@canonical.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).