From: Anand Jain <anand.jain@oracle.com>
To: Qu Wenruo <wqu@suse.com>, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH v3 2/2] btrfs: tree-checker: Fix wrong check on max devid
Date: Tue, 10 Sep 2019 17:07:07 +0800 [thread overview]
Message-ID: <325a8560-b172-0826-95b7-c0922f8e2c50@oracle.com> (raw)
In-Reply-To: <20190828023313.22417-2-wqu@suse.com>
> diff --git a/fs/btrfs/tree-checker.c b/fs/btrfs/tree-checker.c
> index ccd5706199d7..15d1aa7cef1f 100644
> --- a/fs/btrfs/tree-checker.c
> +++ b/fs/btrfs/tree-checker.c
> @@ -686,9 +686,7 @@ static void dev_item_err(const struct extent_buffer *eb, int slot,
> static int check_dev_item(struct extent_buffer *leaf,
> struct btrfs_key *key, int slot)
> {
> - struct btrfs_fs_info *fs_info = leaf->fs_info;
> struct btrfs_dev_item *ditem;
> - u64 max_devid = max(BTRFS_MAX_DEVS(fs_info), BTRFS_MAX_DEVS_SYS_CHUNK);
As I commented in v2.
I see that BTRFS_MAX_DEVS_SYS_CHUNK is not being used anywhere
else after this being removed. So good to delete the define.
I am bit surprised as well if I am missing?
Thanks, Anand
next prev parent reply other threads:[~2019-09-10 9:10 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-28 2:33 [PATCH 1/2] btrfs: Consider system chunk array size for new SYSTEM chunks Qu Wenruo
2019-08-28 2:33 ` [PATCH v3 2/2] btrfs: tree-checker: Fix wrong check on max devid Qu Wenruo
2019-08-28 6:27 ` Nikolay Borisov
2019-08-28 6:30 ` WenRuo Qu
2019-09-10 9:07 ` Anand Jain [this message]
2019-09-10 9:12 ` WenRuo Qu
2019-09-10 9:23 ` Anand Jain
2019-08-28 6:35 ` [PATCH 1/2] btrfs: Consider system chunk array size for new SYSTEM chunks Nikolay Borisov
2019-09-10 14:01 ` Anand Jain
2019-10-24 19:40 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=325a8560-b172-0826-95b7-c0922f8e2c50@oracle.com \
--to=anand.jain@oracle.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).