From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx2.suse.de ([195.135.220.15]:48892 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725887AbeIUMn0 (ORCPT ); Fri, 21 Sep 2018 08:43:26 -0400 Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id BAFE7ACFA for ; Fri, 21 Sep 2018 06:55:55 +0000 (UTC) Subject: Re: [PATCH 2/2] btrfs: relocation: Remove redundant tree level check To: Qu Wenruo , linux-btrfs@vger.kernel.org References: <20180921064521.13102-1-wqu@suse.com> <20180921064521.13102-2-wqu@suse.com> From: Nikolay Borisov Message-ID: <3325272e-9fc2-0247-5a39-be7525f2c1e8@suse.com> Date: Fri, 21 Sep 2018 09:55:55 +0300 MIME-Version: 1.0 In-Reply-To: <20180921064521.13102-2-wqu@suse.com> Content-Type: text/plain; charset=utf-8 Sender: linux-btrfs-owner@vger.kernel.org List-ID: On 21.09.2018 09:45, Qu Wenruo wrote: > Commit 581c1760415c ("btrfs: Validate child tree block's level and first > key") has made tree block level check mandatory. > > So if tree block level doesn't match, we won't get a valid extent > buffer. > The extra WARN_ON() check can be removed completely. > > Signed-off-by: Qu Wenruo Reviewed-by: Nikolay Borisov > --- > fs/btrfs/relocation.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/fs/btrfs/relocation.c b/fs/btrfs/relocation.c > index d7f5a11dde20..56e2fab2926d 100644 > --- a/fs/btrfs/relocation.c > +++ b/fs/btrfs/relocation.c > @@ -2911,7 +2911,6 @@ static int get_tree_block_key(struct btrfs_fs_info *fs_info, > free_extent_buffer(eb); > return -EIO; > } > - WARN_ON(btrfs_header_level(eb) != block->level); > if (block->level == 0) > btrfs_item_key_to_cpu(eb, &block->key, 0); > else >