From: Nikolay Borisov <nborisov@suse.com>
To: Qu Wenruo <wqu@suse.com>, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH v2.1 0/3] btrfs-progs: Check and repair invalid root item generation
Date: Mon, 12 Aug 2019 11:22:56 +0300 [thread overview]
Message-ID: <3772450d-1d34-c67b-246b-f4ff1429d8cb@suse.com> (raw)
In-Reply-To: <20190812063422.22219-1-wqu@suse.com>
On 12.08.19 г. 9:34 ч., Qu Wenruo wrote:
> Kernel is going to reject invalid root generation.
>
> Consider the existing checks are causing some error reports, we should
> handle such problem in advance, so that's the patchset is going to do,
> check and repair such invalid root generation.
>
> Changelog:
> v2:
> - Use existing recow_extent_buffer() to do the repair
>
> v2.1:
> - Add beacon file to allow lowmem mode repair for newly added test case.
>
> Qu Wenruo (3):
> btrfs-progs: check/lowmem: Check and repair root generation
> btrfs-progs: check/original: Check and repair root item geneartion
> btrfs-progs: fsck-tests: Add test case for invalid root generation
>
> check/main.c | 57 +++++++-----------
> check/mode-common.c | 36 +++++++++++
> check/mode-common.h | 1 +
> check/mode-lowmem.c | 17 ++++++
> check/mode-lowmem.h | 1 +
> .../.lowmem_repairable | 0
> .../default_case.img | Bin 0 -> 3072 bytes
> 7 files changed, 76 insertions(+), 36 deletions(-)
> create mode 100644 tests/fsck-tests/041-invalid-root-generation/.lowmem_repairable
> create mode 100644 tests/fsck-tests/041-invalid-root-generation/default_case.img
>
The patchset looks rather trivial - just use recow_extent_buffer when
you find a root with larger generation. So:
Reviewed-by: Nikolay Borisov <nborisov@suse.com>
next prev parent reply other threads:[~2019-08-12 8:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-12 6:34 [PATCH v2.1 0/3] btrfs-progs: Check and repair invalid root item generation Qu Wenruo
2019-08-12 6:34 ` [PATCH v2.1 1/3] btrfs-progs: check/lowmem: Check and repair root generation Qu Wenruo
2019-08-12 6:34 ` [PATCH v2.1 2/3] btrfs-progs: check/original: Check and repair root item geneartion Qu Wenruo
2019-08-12 6:34 ` [PATCH v2.1 3/3] btrfs-progs: fsck-tests: Add test case for invalid root generation Qu Wenruo
2019-08-12 8:22 ` Nikolay Borisov [this message]
2019-08-26 17:07 ` [PATCH v2.1 0/3] btrfs-progs: Check and repair invalid root item generation David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3772450d-1d34-c67b-246b-f4ff1429d8cb@suse.com \
--to=nborisov@suse.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).