From: Nitin Gupta <ngupta@vflare.org>
To: Dan Magenheimer <dan.magenheimer@oracle.com>
Cc: chris.mason@oracle.com, viro@zeniv.linux.org.uk,
akpm@linux-foundation.org, adilger@sun.com, tytso@mit.edu,
mfasheh@suse.com, joel.becker@oracle.com, matthew@wil.cx,
linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org,
ocfs2-devel@oss.oracle.com, linux-mm@kvack.org, jeremy@goop.org,
JBeulich@novell.com, kurt.hackel@oracle.com, npiggin@suse.de,
dave.mccracken@oracle.com, riel@redhat.com, avi@redhat.com,
konrad.wilk@oracle.com
Subject: Re: [PATCH V2 2/7] Cleancache (was Transcendent Memory): core files
Date: Thu, 10 Jun 2010 07:11:52 +0530 [thread overview]
Message-ID: <4C1042E0.8080403@vflare.org> (raw)
In-Reply-To: <20100528173550.GA12219@ca-server1.us.oracle.com>
Hi,
On 05/28/2010 11:05 PM, Dan Magenheimer wrote:
> [PATCH V2 2/7] Cleancache (was Transcendent Memory): core files
I just finished a rough (but working) implementation of in-kernel
page cache compression backend (called zcache). During this work,
I found some issues with cleancache, mostly related to (lack of)
comments/documentation:
> +
> +static inline int cleancache_init_fs(size_t pagesize)
> +
- It is not very obvious that this function is called when
an instance of cleancache supported filesystem is *mounted*.
Initially, I thought this is called which any such filesystem
module is loaded.
- It seems that returning pool_id of 0 is considered as error
condition (as it appears from deactivate_locked_super() changes).
This seems weird; I think only negative pool_id should considered
as error. Anyway, please add function comments for these.
> +int __cleancache_get_page(struct page *page)
> +{
> + int ret = 0;
> + int pool_id = page->mapping->host->i_sb->cleancache_poolid;
> +
> + if (pool_id >= 0) {
> + ret = (*cleancache_ops->get_page)(pool_id,
> + page->mapping->host->i_ino,
> + page->index,
> + page);
> + if (ret == CLEANCACHE_GET_PAGE_SUCCESS)
> + succ_gets++;
> + else
> + failed_gets++;
> + }
> + return ret;
> +}
It seems "non-standard" to use '1' as success code. You could simply use
0 for success and negative error code as failure. Then you can also get
rid of CLEANCACHE_GET_PAGE_SUCCESS.
> +
> +int __cleancache_put_page(struct page *page)
What return values stands for successful put? 1? Anyway, following the
same, 0 for success, negative codes for errors, seems to be better.
> +
> +int __cleancache_flush_page(struct address_space *mapping, struct page *page)
> +int __cleancache_flush_inode(struct address_space *mapping)
Return values for all the flush functions is ignored everywhere, so
why not make them return void instead?
> +static inline void cleancache_flush_fs(int pool_id)
Like init_fs, please document that it is called when a cleancache
aware filesystem is unmounted (or in other cases too?).
Page cache compression was a long-pending project. I'm glad its
coming into shape with the help of cleancache :)
Thanks,
Nitin
next prev parent reply other threads:[~2010-06-10 1:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20100528173550.GA12219@ca-server1.us.oracle.com>
2010-06-02 19:29 ` [PATCH V2 2/7] Cleancache (was Transcendent Memory): core files Andrew Morton
2010-06-03 0:06 ` Dan Magenheimer
2010-06-03 0:21 ` Jeremy Fitzhardinge
2010-06-03 2:47 ` Dan Magenheimer
2010-06-10 1:41 ` Nitin Gupta [this message]
2010-06-10 3:28 ` Dan Magenheimer
2010-05-28 17:35 Dan Magenheimer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C1042E0.8080403@vflare.org \
--to=ngupta@vflare.org \
--cc=JBeulich@novell.com \
--cc=adilger@sun.com \
--cc=akpm@linux-foundation.org \
--cc=avi@redhat.com \
--cc=chris.mason@oracle.com \
--cc=dan.magenheimer@oracle.com \
--cc=dave.mccracken@oracle.com \
--cc=jeremy@goop.org \
--cc=joel.becker@oracle.com \
--cc=konrad.wilk@oracle.com \
--cc=kurt.hackel@oracle.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=matthew@wil.cx \
--cc=mfasheh@suse.com \
--cc=npiggin@suse.de \
--cc=ocfs2-devel@oss.oracle.com \
--cc=riel@redhat.com \
--cc=tytso@mit.edu \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).