linux-btrfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Yan, Zheng" <zheng.yan@oracle.com>
To: miaox@cn.fujitsu.com
Cc: Chris Mason <chris.mason@oracle.com>,
	Linux Btrfs <linux-btrfs@vger.kernel.org>
Subject: Re: [BUG] btrfs hangup when we run the "sync" command
Date: Mon, 19 Jul 2010 10:01:26 +0800	[thread overview]
Message-ID: <4C43B1F6.6070601@oracle.com> (raw)
In-Reply-To: <4C43B0B2.1040507@cn.fujitsu.com>

On 07/19/2010 09:56 AM, Miao Xie wrote:
> On Thu, 15 Jul 2010 12:12:13 -0400, Chris Mason <chris.mason@oracle.com> wrote:
>>>>> It seems that the btrfs doesn't support the sectorsize which is
>>>>> greater than the page size just like ext2/3/4, though we can use
>>>>> mkfs.btrfs to make a filesystem with a big sectorsize. Am I right?
>>>>>
>>>>> If yes, we must do more check in the mkfs.btrfs.
>>>>>
>>>>
>>>> yes, btrfs doesn't support the sectorsize>  PAGE_size.
>>>>
>>>
>>> So we must do more check in the mkfs.btrfs to avoid misuse, and I'll
>>> add some check of the sectorsize into the mkfs.btrfs.
>>
>> Yes, but this is fixed up with the raid code, we'll allow different page
>> sizes.
> 
> Is the raid code that you said the initialization code for the block devices?
> just like this:
> 
> fs/btrfs/volumes.c:1430
> int btrfs_init_new_device(struct btrfs_root *root, char *device_path)
> {
> 	[snip]
> 	set_blocksize(device->bdev, 4096);
> 	[snip]
> }
> 
> If yes, it uses a hard-code value to initialize the blocksize of the block device,
> not the blocksize of the btrfs, so the btrfs doesn't check the blocksize of the btrfs.
> 

This is for btrfs super block, because size of btrfs super block is fixed.

Yan, Zheng


  reply	other threads:[~2010-07-19  2:01 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-15  3:18 [BUG] btrfs hangup when we run the "sync" command Miao Xie
2010-07-15  8:14 ` Yan, Zheng
2010-07-15  9:07   ` Miao Xie
2010-07-15 16:12     ` Chris Mason
2010-07-19  1:56       ` Miao Xie
2010-07-19  2:01         ` Yan, Zheng [this message]
2010-07-19  6:17           ` Miao Xie
2010-07-19  6:46             ` Yan, Zheng
2010-07-19  8:29               ` Miao Xie
2010-07-21 12:36     ` Hubert Kario

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C43B1F6.6070601@oracle.com \
    --to=zheng.yan@oracle.com \
    --cc=chris.mason@oracle.com \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=miaox@cn.fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).