From: Wang Shilong <wangsl.fnst@cn.fujitsu.com>
To: Anand Jain <Anand.Jain@oracle.com>
Cc: <dsterba@suse.cz>, <linux-btrfs@vger.kernel.org>
Subject: Re: [PATCH] Btrfs-progs: save us an unnecessary ioctl call
Date: Fri, 16 May 2014 12:58:46 +0800 [thread overview]
Message-ID: <53759B06.9030109@cn.fujitsu.com> (raw)
In-Reply-To: <537594D9.8010902@oracle.com>
Hi Anand,
On 05/16/2014 12:32 PM, Anand Jain wrote:
>
> David,
>
> As mentioned, this patch will back-out the earlier patch
>
> 50275bacab0f62b91453fbfa29e75c2bb77bf9b6
>
> I am confused on what I am missing ? Any comment?
You are right, i guess dave just missed your previous thread.:-)
dave, please ignore my patch, sorry for noise.
Thanks,
Wang
>
> Thanks, Anand
>
>
> On 16/05/14 01:06, David Sterba wrote:
>> On Tue, May 13, 2014 at 05:05:05PM +0800, Wang Shilong wrote:
>>> Btrfs device id start from 1, not 0.
>>
>>> --- a/utils.c
>>> +++ b/utils.c
>>> @@ -1765,7 +1765,7 @@ int get_fs_info(char *path, struct
>>> btrfs_ioctl_fs_info_args *fi_args,
>>> goto out;
>>> }
>>>
>>> - for (; i <= fi_args->max_id; ++i) {
>>> + for (i = 1; i <= fi_args->max_id; ++i) {
>>
>> You're right about the device id start, but forcing 1 here breaks the
>> case when get_fs_info is called with block device as an argument and 'i'
>> is set to the devid a few lines above.
>>
>> Initializing i to 1 in the declaration block is the right fix IMO, and
>> as this is a trivial change I'll do that myself, no need to resend.
>>
>>> BUG_ON(ndevs >= fi_args->num_devices);
>>> ret = get_device_info(fd, i, &di_args[ndevs]);
>>> if (ret == -ENODEV)
>> --
>> To unsubscribe from this list: send the line "unsubscribe
>> linux-btrfs" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>>
> .
>
next prev parent reply other threads:[~2014-05-16 5:02 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-13 9:05 [PATCH] Btrfs-progs: save us an unnecessary ioctl call Wang Shilong
2014-05-13 9:05 ` [PATCH] Btrfs: set right total device count for seeding support Wang Shilong
2014-05-16 14:14 ` Anand Jain
2014-05-16 14:44 ` Anand Jain
2014-05-16 14:50 ` Shilong Wang
2014-05-16 15:06 ` Anand Jain
2014-05-16 14:45 ` Shilong Wang
2014-05-13 10:48 ` [PATCH] Btrfs-progs: save us an unnecessary ioctl call Stefan Behrens
2014-05-13 11:26 ` Wang Shilong
2014-05-14 5:32 ` Anand Jain
2014-05-15 17:06 ` David Sterba
2014-05-16 4:32 ` Anand Jain
2014-05-16 4:58 ` Wang Shilong [this message]
2014-05-16 12:14 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53759B06.9030109@cn.fujitsu.com \
--to=wangsl.fnst@cn.fujitsu.com \
--cc=Anand.Jain@oracle.com \
--cc=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).