From: Qu Wenruo <quwenruo@cn.fujitsu.com>
To: Mike Fleetwood <mike.fleetwood@googlemail.com>
Cc: linux-btrfs <linux-btrfs@vger.kernel.org>
Subject: Re: [PATCH] btrfs-progs: Add dev uuid output for print_dev_item().
Date: Fri, 30 May 2014 08:58:18 +0800 [thread overview]
Message-ID: <5387D7AA.3040000@cn.fujitsu.com> (raw)
In-Reply-To: <CAMU1PDhBuk46VgwNVnO_1JzOgZka1wd8dMvTjECwTRBsfZeghQ@mail.gmail.com>
-------- Original Message --------
Subject: Re: [PATCH] btrfs-progs: Add dev uuid output for print_dev_item().
From: Mike Fleetwood <mike.fleetwood@googlemail.com>
To: Qu Wenruo <quwenruo@cn.fujitsu.com>
Date: 2014年05月30日 03:52
> On 29 May 2014 02:02, Qu Wenruo <quwenruo@cn.fujitsu.com> wrote:
>> The original print_dev_item() only prints device id,total bytes and
>> bytes used.
>> When it comes to debug things related to duplicated device id, dev uuid
>> is needed to distinguish different device since device is is no
>> reliable.
> At the end of the message I think there is a couple of typos and you meant:
> ... device id is not reliable.
Yes, it is not reliable when comes to reappered missing devices.
If you mounted btrfs with missing device using degraded mode and
replaced missing device,
but the missing device reappered, then devices with same dev uuid will
show up.
Thanks,
Qu
>
>> This patch added dev uuid output.
>>
>> Signed-off-by: Qu Wenruo <quwenruo@cn.fujitsu.com>
>> ---
>> print-tree.c | 13 +++++++++++--
>> 1 file changed, 11 insertions(+), 2 deletions(-)
> Thanks,
> Mike
> --
> To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2014-05-30 0:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-29 1:02 [PATCH] btrfs-progs: Add dev uuid output for print_dev_item() Qu Wenruo
2014-05-29 19:52 ` Mike Fleetwood
2014-05-30 0:58 ` Qu Wenruo [this message]
2014-06-02 17:43 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5387D7AA.3040000@cn.fujitsu.com \
--to=quwenruo@cn.fujitsu.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=mike.fleetwood@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).