linux-btrfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] btrfs: kobject_uevent should use bd_part instead of bd_disk
@ 2014-05-30  7:50 Anand Jain
  2014-05-30 10:20 ` Anand Jain
  0 siblings, 1 reply; 2+ messages in thread
From: Anand Jain @ 2014-05-30  7:50 UTC (permalink / raw)
  To: linux-btrfs; +Cc: dsterba, quwenruo, clm

From: Anand Jain <Anand.Jain@oracle.com>

reproducer 1:
 mkfs.btrfs -L test /dev/sdg1
 mount LABEL=test /btrfs
 btrfs dev add /dev/sdg2 /btrfs
 btrfs dev del /dev/sdg1 /btrfs
 umount /btrfs
 mount LABEL=test /btrfs
   mount: special device LABEL-test1 does not exist

 It does not reproduce this problem when whole disk is used.
 And when newer kernel is used not sure what change in udev
 is doing the trick. But in any case reproducer2 below is
 more compelling.

reproducer 2:
 btrfs dev del /dev/sdh2 /btrfs
 ls -l /dev/sdh1 /dev/sdh2 /dev/sdh3
 mtime of deleted disk is stale.

 Fix it by providing bd_part for the kobject_uevent().

 I have tested to confirm it doesn't break on the same thing
 when whole disk is used.

Reported-by: Qu Wenruo <quwenruo@cn.fujitsu.com>
Reported-by: Tsutomu Itoh <t-itoh@jp.fujitsu.com>
Signed-off-by: Anand Jain <Anand.Jain@oracle.com>
---
 fs/btrfs/volumes.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/fs/btrfs/volumes.c b/fs/btrfs/volumes.c
index f58ea9e..1aba687 100644
--- a/fs/btrfs/volumes.c
+++ b/fs/btrfs/volumes.c
@@ -124,7 +124,7 @@ static void btrfs_kobject_uevent(struct block_device *bdev,
 {
 	int ret;
 
-	ret = kobject_uevent(&disk_to_dev(bdev->bd_disk)->kobj, action);
+	ret = kobject_uevent(&part_to_dev(bdev->bd_part)->kobj, action);
 	if (ret)
 		pr_warn("BTRFS: Sending event '%d' to kobject: '%s' (%p): failed\n",
 			action,
-- 
1.7.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] btrfs: kobject_uevent should use bd_part instead of bd_disk
  2014-05-30  7:50 [PATCH] btrfs: kobject_uevent should use bd_part instead of bd_disk Anand Jain
@ 2014-05-30 10:20 ` Anand Jain
  0 siblings, 0 replies; 2+ messages in thread
From: Anand Jain @ 2014-05-30 10:20 UTC (permalink / raw)
  To: linux-btrfs; +Cc: dsterba, quwenruo, clm


   Nack for this as of now. sorry. Qu finds, this doesn't fix.
   my test case was dev delete and then ls -l dev by hand.
   Qu's test case is same but a script. Looks like that time
   gap is the key.

   Looking more.

Thanks,  Anand


On 30/05/14 15:50, Anand Jain wrote:
> From: Anand Jain <Anand.Jain@oracle.com>
>
> reproducer 1:
>   mkfs.btrfs -L test /dev/sdg1
>   mount LABEL=test /btrfs
>   btrfs dev add /dev/sdg2 /btrfs
>   btrfs dev del /dev/sdg1 /btrfs
>   umount /btrfs
>   mount LABEL=test /btrfs
>     mount: special device LABEL-test1 does not exist
>
>   It does not reproduce this problem when whole disk is used.
>   And when newer kernel is used not sure what change in udev
>   is doing the trick. But in any case reproducer2 below is
>   more compelling.
>
> reproducer 2:
>   btrfs dev del /dev/sdh2 /btrfs
>   ls -l /dev/sdh1 /dev/sdh2 /dev/sdh3
>   mtime of deleted disk is stale.
>
>   Fix it by providing bd_part for the kobject_uevent().
>
>   I have tested to confirm it doesn't break on the same thing
>   when whole disk is used.
>
> Reported-by: Qu Wenruo <quwenruo@cn.fujitsu.com>
> Reported-by: Tsutomu Itoh <t-itoh@jp.fujitsu.com>
> Signed-off-by: Anand Jain <Anand.Jain@oracle.com>
> ---
>   fs/btrfs/volumes.c |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/fs/btrfs/volumes.c b/fs/btrfs/volumes.c
> index f58ea9e..1aba687 100644
> --- a/fs/btrfs/volumes.c
> +++ b/fs/btrfs/volumes.c
> @@ -124,7 +124,7 @@ static void btrfs_kobject_uevent(struct block_device *bdev,
>   {
>   	int ret;
>
> -	ret = kobject_uevent(&disk_to_dev(bdev->bd_disk)->kobj, action);
> +	ret = kobject_uevent(&part_to_dev(bdev->bd_part)->kobj, action);
>   	if (ret)
>   		pr_warn("BTRFS: Sending event '%d' to kobject: '%s' (%p): failed\n",
>   			action,
>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2014-05-30 10:17 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-05-30  7:50 [PATCH] btrfs: kobject_uevent should use bd_part instead of bd_disk Anand Jain
2014-05-30 10:20 ` Anand Jain

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).