From: "Holger Hoffstätte" <holger@applied-asynchrony.com>
To: linux-btrfs@vger.kernel.org
Subject: Re: Scrub resume regression
Date: Wed, 15 Jan 2020 14:10:42 +0100 [thread overview]
Message-ID: <5aa23833-d1e2-fe6f-7c6e-f366d3eccbe3@applied-asynchrony.com> (raw)
In-Reply-To: <20200115125134.GN3929@twin.jikos.cz>
On 1/15/20 1:51 PM, David Sterba wrote:
>> It is important that scrub always returns the stats, even when it
>> returns an error. This is critical for cancel, as that is how
>> cancel/resume works, but it should also apply in case of other errors so
>> that the user can see how much of the scrub was done before the fatal error.
>
> That's something we need to document in code and perhaps in the manual
> pages too.
Isn't the real problem that cancel does not actually mean cancel,
but rather also implies "..and maybe continue"? IMHO cancel should cancel
(and say how much work was performed), while the intention to resume should
be called e.g. "pause". This makes the behaviour clear and prevents
accidental semantic overlap.
-h
next prev parent reply other threads:[~2020-01-15 13:10 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-15 9:03 Scrub resume regression Graham Cobb
2020-01-15 9:33 ` Filipe Manana
2020-01-15 11:55 ` Graham Cobb
2020-01-15 12:51 ` David Sterba
2020-01-15 13:10 ` Holger Hoffstätte [this message]
2020-01-15 21:02 ` Sebastian Döring
2020-01-16 14:02 ` David Sterba
2020-01-17 15:59 ` Zygo Blaxell
2020-01-17 18:39 ` Chris Murphy
2020-01-17 19:39 ` Graham Cobb
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5aa23833-d1e2-fe6f-7c6e-f366d3eccbe3@applied-asynchrony.com \
--to=holger@applied-asynchrony.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).