[PATCH 0/2] Unused code cleanups

[PATCH 0/2] Unused code cleanups

[David Sterba]

David Sterba (2):
  btrfs: remove unused btrfs_device::flush_bio_sent
  btrfs: remove unused key type set/get helpers

 fs/btrfs/ctree.h   | 10 ----------
 fs/btrfs/volumes.h |  1 -
 2 files changed, 11 deletions(-)

-- 
2.22.0

[PATCH 1/2] btrfs: remove unused btrfs_device::flush_bio_sent

[David Sterba]

The status of flush bio is tracked as a status bit, changed in commit
1c3063b6dbfa ("btrfs: cleanup device states define
BTRFS_DEV_STATE_FLUSH_SENT"), the flush_bio_sent was forgotten.

Signed-off-by: David Sterba <dsterba@suse.com>
---
 fs/btrfs/volumes.h | 1 -
 1 file changed, 1 deletion(-)

diff --git a/fs/btrfs/volumes.h b/fs/btrfs/volumes.h
index c71354fe1363..081cb734a239 100644
--- a/fs/btrfs/volumes.h
+++ b/fs/btrfs/volumes.h
@@ -82,7 +82,6 @@ struct btrfs_device {
 
 	unsigned long dev_state;
 	blk_status_t last_flush_error;
-	int flush_bio_sent;
 
 #ifdef __BTRFS_NEED_DEVICE_DATA_ORDERED
 	seqcount_t data_seqcount;
-- 
2.22.0

[PATCH 2/2] btrfs: remove unused key type set/get helpers

[David Sterba]

The switch to open coded set/get has happend long time ago in
962a298f3511 ("btrfs: kill the key type accessor helpers"), remove the
stray helpers.

Signed-off-by: David Sterba <dsterba@suse.com>
---
 fs/btrfs/ctree.h | 10 ----------
 1 file changed, 10 deletions(-)

diff --git a/fs/btrfs/ctree.h b/fs/btrfs/ctree.h
index 1110bbd4bffb..3af3f680b5f1 100644
--- a/fs/btrfs/ctree.h
+++ b/fs/btrfs/ctree.h
@@ -2072,16 +2072,6 @@ static inline void btrfs_dir_item_key_to_cpu(const struct extent_buffer *eb,
 	btrfs_disk_key_to_cpu(key, &disk_key);
 }
 
-static inline u8 btrfs_key_type(const struct btrfs_key *key)
-{
-	return key->type;
-}
-
-static inline void btrfs_set_key_type(struct btrfs_key *key, u8 val)
-{
-	key->type = val;
-}
-
 /* struct btrfs_header */
 BTRFS_SETGET_HEADER_FUNCS(header_bytenr, struct btrfs_header, bytenr, 64);
 BTRFS_SETGET_HEADER_FUNCS(header_generation, struct btrfs_header,
-- 
2.22.0

Re: [PATCH 1/2] btrfs: remove unused btrfs_device::flush_bio_sent

[Anand Jain]

On 8/2/19 1:53 AM, David Sterba wrote:
> The status of flush bio is tracked as a status bit, changed in commit
> 1c3063b6dbfa ("btrfs: cleanup device states define
> BTRFS_DEV_STATE_FLUSH_SENT"), the flush_bio_sent was forgotten.
> 
> Signed-off-by: David Sterba <dsterba@suse.com>

oops my bad.

Reviewed-by: Anand Jain <anand.jain@oracle.com>

Re: [PATCH 2/2] btrfs: remove unused key type set/get helpers

[Anand Jain]

On 8/2/19 1:53 AM, David Sterba wrote:
> The switch to open coded set/get has happend long time ago in
> 962a298f3511 ("btrfs: kill the key type accessor helpers"), remove the
> stray helpers.
> 
> Signed-off-by: David Sterba <dsterba@suse.com>

Reviewed-by: Anand Jain <anand.jain@oracle.com>