From: Nikolay Borisov <nborisov@suse.com>
To: dsterba@suse.cz, Josef Bacik <josef@toxicpanda.com>,
linux-btrfs@vger.kernel.org, kernel-team@fb.com
Subject: Re: [PATCH 0/5][v2] Deal with a few ENOSPC corner cases
Date: Wed, 25 Mar 2020 17:52:38 +0200 [thread overview]
Message-ID: <5e9163f3-60d3-e656-7283-9c2a2ed4dfc8@suse.com> (raw)
In-Reply-To: <20200325155031.GE5920@twin.jikos.cz>
On 25.03.20 г. 17:50 ч., David Sterba wrote:
> On Fri, Mar 13, 2020 at 03:58:04PM -0400, Josef Bacik wrote:
>> v1->v2:
>> - Dropped "btrfs: only take normal tickets into account in
>> may_commit_transaction" because "btrfs: only check priority tickets for
>> priority flushing" should actually fix the problem, and Nikolay pointed out
>> that evict uses the priority list but is allowed to commit, so we need to take
>> into account priority tickets sometimes.
>> - Added "btrfs: allow us to use up to 90% of the global rsv for" so that the
>> global rsv change was separate from the serialization patch.
>> - Fixed up some changelogs.
>> - Dropped an extra trace_printk that made it into v2.
>
> The patchset seems to be based on some other, code I think it's the
> tickets for data chunks. The compilation fails because
> BTRFS_RESERVE_FLUSH_DATA is not defined, but it's mentioned in several
> patches.
>
> If the base patchset is a hard requirement then both would need to go in
> at the same time, otherwise if it's possible to refresh this branch I
> could add it to for-next now.
>
No, the data ticket is not a hard requirement. I've tested this branch
on our SLE kernels without it. So the conflict resolution is really mino
- simply removing the conditions involving BTRFS_RESERVE_FLUSH_DATA.
next prev parent reply other threads:[~2020-03-25 15:52 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-13 19:58 [PATCH 0/5][v2] Deal with a few ENOSPC corner cases Josef Bacik
2020-03-13 19:58 ` [PATCH 1/5] btrfs: Improve global reserve stealing logic Josef Bacik
2020-03-17 12:46 ` Nikolay Borisov
2020-03-13 19:58 ` [PATCH 2/5] btrfs: allow us to use up to 90% of the global rsv for unlink Josef Bacik
2020-03-17 12:46 ` Nikolay Borisov
2020-03-13 19:58 ` [PATCH 3/5] btrfs: Account for trans_block_rsv in may_commit_transaction Josef Bacik
2020-03-13 19:58 ` [PATCH 4/5] btrfs: only check priority tickets for priority flushing Josef Bacik
2020-03-17 12:55 ` Nikolay Borisov
2020-03-13 19:58 ` [PATCH 5/5] btrfs: run btrfs_try_granting_tickets if a priority ticket fails Josef Bacik
2020-03-17 12:59 ` Nikolay Borisov
2020-03-17 15:46 ` [PATCH 0/5][v2] Deal with a few ENOSPC corner cases Nikolay Borisov
2020-03-25 15:50 ` David Sterba
2020-03-25 15:52 ` Nikolay Borisov [this message]
2020-03-25 18:33 ` David Sterba
2020-04-03 15:46 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5e9163f3-60d3-e656-7283-9c2a2ed4dfc8@suse.com \
--to=nborisov@suse.com \
--cc=dsterba@suse.cz \
--cc=josef@toxicpanda.com \
--cc=kernel-team@fb.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).