From: Nikolay Borisov <nborisov@suse.com>
To: Anand Jain <anand.jain@oracle.com>, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 05/15] btrfs: refactor btrfs_sysfs_remove_devices_dir
Date: Thu, 3 Sep 2020 11:47:32 +0300 [thread overview]
Message-ID: <62034c35-7eba-bfe8-5d6c-bcad4e6a94be@suse.com> (raw)
In-Reply-To: <86f446238ee7f610090b79342ecf472453d9da4c.1599091832.git.anand.jain@oracle.com>
On 3.09.20 г. 3:57 ч., Anand Jain wrote:
> Similar to btrfs_sysfs_add_devices_dir()'s refactor, refactor
> btrfs_sysfs_remove_devices_dir() so that we don't have to use the 2nd
> argument to indicate whether to free all devices or just one device.
>
> Make btrfs_sysfs_remove_device() global as device operations outside of
> sysfs.c now calls this instead of btrfs_sysfs_remove_devices_dir().
>
> btrfs_sysfs_remove_devices_dir() is renamed to
> btrfs_sysfs_remove_fs_devices() to suite its new role.
>
> Now, no one outside of sysfs.c calls btrfs_sysfs_remove_fs_devices()
> so it is redeclared as static. And the same function had to be moved
> before its first caller.
>
> Signed-off-by: Anand Jain <anand.jain@oracle.com>
Reviewed-by: Nikolay Borisov <nborisov@suse.com>
> ---
> fs/btrfs/dev-replace.c | 2 +-
> fs/btrfs/sysfs.c | 27 +++++++++++----------------
> fs/btrfs/sysfs.h | 3 +--
> fs/btrfs/volumes.c | 8 ++++----
> 4 files changed, 17 insertions(+), 23 deletions(-)
>
<snip>
> diff --git a/fs/btrfs/volumes.c b/fs/btrfs/volumes.c
> index 8952f7031f4b..9921b43ef839 100644
> --- a/fs/btrfs/volumes.c
> +++ b/fs/btrfs/volumes.c
> @@ -2040,7 +2040,7 @@ void btrfs_scratch_superblocks(struct btrfs_fs_info *fs_info,
> }
>
> int btrfs_rm_device(struct btrfs_fs_info *fs_info, const char *device_path,
> - u64 devid)
> + u64 devid)
nit: Though I agree with this change it's unrelated.
> {
> struct btrfs_device *device;
> struct btrfs_fs_devices *cur_devices;
<snip>
next prev parent reply other threads:[~2020-09-03 8:47 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-03 0:57 [PATCH v2 0/15] btrfs: seed fix null ptr, use only main device_list_mutex, and cleanups Anand Jain
2020-09-03 0:57 ` [PATCH 01/15] btrfs: add btrfs_sysfs_add_device helper Anand Jain
2020-09-03 8:40 ` Nikolay Borisov
2020-09-03 9:36 ` Anand Jain
2020-09-03 10:14 ` Anand Jain
2020-09-03 0:57 ` [PATCH 02/15] btrfs: add btrfs_sysfs_remove_device helper Anand Jain
2020-09-03 8:44 ` Nikolay Borisov
2020-09-03 10:03 ` Anand Jain
2020-09-03 10:09 ` Nikolay Borisov
2020-09-03 15:43 ` Josef Bacik
2020-09-03 0:57 ` [PATCH 03/15] btrfs: btrfs_sysfs_remove_devices_dir drop return value Anand Jain
2020-09-03 8:42 ` Nikolay Borisov
2020-09-03 15:44 ` Josef Bacik
2020-09-03 0:57 ` [PATCH 04/15] btrfs: refactor btrfs_sysfs_add_devices_dir Anand Jain
2020-09-03 8:45 ` Nikolay Borisov
2020-09-03 15:44 ` Josef Bacik
2020-09-03 0:57 ` [PATCH 05/15] btrfs: refactor btrfs_sysfs_remove_devices_dir Anand Jain
2020-09-03 8:47 ` Nikolay Borisov [this message]
2020-09-03 0:57 ` [PATCH 06/15] btrfs: initialize sysfs devid and device link for seed device Anand Jain
2020-09-03 9:06 ` Nikolay Borisov
2020-09-03 11:35 ` Anand Jain
2020-09-04 11:28 ` David Sterba
2020-09-03 0:57 ` [PATCH 07/15] btrfs: handle fail path for btrfs_sysfs_add_fs_devices Anand Jain
2020-09-03 9:13 ` Nikolay Borisov
2020-09-04 9:24 ` [PATCH v3 " Anand Jain
2020-09-03 0:57 ` [PATCH 08/15] btrfs: reada: use sprout device_list_mutex Anand Jain
2020-09-03 0:57 ` [PATCH 09/15] btrfs: btrfs_init_devices_late: " Anand Jain
2020-09-03 0:57 ` [PATCH 10/15] btrfs: open code list_head pointer in btrfs_init_dev_replace_tgtdev Anand Jain
2020-09-03 0:57 ` [PATCH 11/15] btrfs: cleanup btrfs_remove_chunk Anand Jain
2020-09-03 0:57 ` [PATCH 12/15] btrfs: cleanup btrfs_assign_next_active_device() Anand Jain
2020-09-03 0:57 ` [PATCH 13/15] btrfs: cleanup unnecessary goto in open_seed_device Anand Jain
2020-09-03 0:57 ` [PATCH 14/15] btrfs: btrfs_dev_replace_update_device_in_mapping_tree drop file global declare Anand Jain
2020-09-03 0:57 ` [PATCH 15/15] btrfs: fix replace of seed device Anand Jain
2020-09-03 10:46 ` [PATCH v3 1/15] btrfs: add btrfs_sysfs_add_device helper Anand Jain
2020-09-03 15:42 ` Josef Bacik
2020-09-03 11:35 ` [PATCH] fstests: btrfs/161: extend the test case to delete seed Anand Jain
2020-09-03 15:46 ` Josef Bacik
2020-09-04 9:13 ` [PATCH] btrfs: add a test case for btrfs seed device delete Anand Jain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=62034c35-7eba-bfe8-5d6c-bcad4e6a94be@suse.com \
--to=nborisov@suse.com \
--cc=anand.jain@oracle.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).