From: Nikolay Borisov <nborisov@suse.com>
To: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
Cc: dsterba@suse.com, linux-btrfs@vger.kernel.org,
Marcos Paulo de Souza <mpdesouza@suse.com>
Subject: Re: [PATCH 2/2] btrfs-progs: mkfs-tests: Change $dev1 to TEST_DEV
Date: Tue, 10 Dec 2019 10:34:43 +0200 [thread overview]
Message-ID: <63d9002a-e590-136a-f82c-01affeeb9835@suse.com> (raw)
In-Reply-To: <20191205153647.31961-2-marcos.souza.org@gmail.com>
On 5.12.19 г. 17:36 ч., Marcos Paulo de Souza wrote:
> From: Marcos Paulo de Souza <mpdesouza@suse.com>
>
> It seems to be a typo, since $dev1 was not set, and we are dealing with
> TEST_DEV and not with loop devices.
>
> Signed-off-by: Marcos Paulo de Souza <mpdesouza@suse.com>
Reviewed-by: Nikolay Borisov <nborisov@suse.com>
> ---
> tests/mkfs-tests/020-basic-checksums-mount/test.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/mkfs-tests/020-basic-checksums-mount/test.sh b/tests/mkfs-tests/020-basic-checksums-mount/test.sh
> index b7252786..42bf5fab 100755
> --- a/tests/mkfs-tests/020-basic-checksums-mount/test.sh
> +++ b/tests/mkfs-tests/020-basic-checksums-mount/test.sh
> @@ -17,7 +17,7 @@ test_mkfs_mount_checksum()
> run_check $SUDO_HELPER "$TOP/btrfs" inspect-internal dump-super "$TEST_DEV"
> run_check $SUDO_HELPER "$TOP/btrfs" check "$TEST_DEV"
>
> - run_check $SUDO_HELPER mount "$dev1" "$TEST_MNT"
> + run_check $SUDO_HELPER mount "$TEST_DEV" "$TEST_MNT"
> run_check "$TOP/btrfs" filesystem df "$TEST_MNT"
> run_check $SUDO_HELPER "$TOP/btrfs" filesystem usage "$TEST_MNT"
> run_check $SUDO_HELPER "$TOP/btrfs" device usage "$TEST_MNT"
>
next prev parent reply other threads:[~2019-12-10 8:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-05 15:36 [PATCH 1/2] btrfs-progs: mkfs-tests: Set $csum so mkfs.btrfs does not fail Marcos Paulo de Souza
2019-12-05 15:36 ` [PATCH 2/2] btrfs-progs: mkfs-tests: Change $dev1 to TEST_DEV Marcos Paulo de Souza
2019-12-10 8:34 ` Nikolay Borisov [this message]
2019-12-10 8:33 ` [PATCH 1/2] btrfs-progs: mkfs-tests: Set $csum so mkfs.btrfs does not fail Nikolay Borisov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=63d9002a-e590-136a-f82c-01affeeb9835@suse.com \
--to=nborisov@suse.com \
--cc=dsterba@suse.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=marcos.souza.org@gmail.com \
--cc=mpdesouza@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).