From: Nikolay Borisov <nborisov@suse.com>
To: Boris Burkov <boris@bur.io>, fstests@vger.kernel.org
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH v2] btrfs: add test for free space tree remounts
Date: Fri, 4 Sep 2020 10:51:36 +0300 [thread overview]
Message-ID: <76d905d1-5686-932f-8745-fd76d2f6019e@suse.com> (raw)
In-Reply-To: <d63835858b32cf692993766caa3650eec83d8b32.1599178894.git.boris@bur.io>
On 4.09.20 г. 3:25 ч., Boris Burkov wrote:
> btrfs/131 covers a solid variety of free space tree scenarios, but it
> does not cover remount scenarios. We are adding remount support for read
> only btrfs filesystems to move to the free space tree, so add a few test
> cases covering that workflow as well. Refactor out some common free
> space tree code from btrfs/131 into common/btrfs.
>
> Signed-off-by: Boris Burkov <boris@bur.io>
Generally LGTM, but I wonder if it would be beneficial to refer the
series which is supposed to make this test pass. If you look at other
patches in xfstest that's done in the header of the test i.e "This test
freespace remount behavior introduced by xxxx" and you refer to the name
of the patches (or alternatively the commit id if the patch has landed
upstream).
In any case:
Reviewed-by: Nikolay Borisov <nborisov@suse.com>
next prev parent reply other threads:[~2020-09-04 7:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-31 23:05 [PATCH] btrfs: add test for free space tree remounts Boris Burkov
2020-09-01 10:42 ` Nikolay Borisov
2020-09-04 0:25 ` [PATCH v2] " Boris Burkov
2020-09-04 7:51 ` Nikolay Borisov [this message]
2020-09-13 16:49 ` Eryu Guan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=76d905d1-5686-932f-8745-fd76d2f6019e@suse.com \
--to=nborisov@suse.com \
--cc=boris@bur.io \
--cc=fstests@vger.kernel.org \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).