From: Johannes Thumshirn <jthumshirn@suse.de>
To: fdmanana@kernel.org, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] Btrfs: do not overwrite error return value in the get device stats ioctl
Date: Mon, 17 Dec 2018 09:45:42 +0100 [thread overview]
Message-ID: <76eb6a5d-68db-c15b-dc9d-1a55607a8813@suse.de> (raw)
In-Reply-To: <20181214194522.21791-1-fdmanana@kernel.org>
Looks good,
Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>
But I agree with Nick's review on the scrub progress ioctl patch,
splitting the error handling into two parts is easier to read.
--
Johannes Thumshirn SUSE Labs Filesystems
jthumshirn@suse.de +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
prev parent reply other threads:[~2018-12-17 8:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-14 19:45 [PATCH] Btrfs: do not overwrite error return value in the get device stats ioctl fdmanana
2018-12-17 8:45 ` Johannes Thumshirn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=76eb6a5d-68db-c15b-dc9d-1a55607a8813@suse.de \
--to=jthumshirn@suse.de \
--cc=fdmanana@kernel.org \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).