From: "Austin S. Hemmelgarn" <firstname.lastname@example.org> To: Andrei Borzenkov <email@example.com>, Chris Murphy <firstname.lastname@example.org> Cc: Adam Borowski <email@example.com>, Btrfs BTRFS <firstname.lastname@example.org> Subject: Re: updatedb does not index /home when /home is Btrfs Date: Mon, 6 Nov 2017 08:51:11 -0500 [thread overview] Message-ID: <email@example.com> (raw) In-Reply-To: <firstname.lastname@example.org> On 2017-11-05 03:01, Andrei Borzenkov wrote: > 04.11.2017 21:55, Chris Murphy пишет: >> On Sat, Nov 4, 2017 at 12:27 PM, Andrei Borzenkov <email@example.com> wrote: >>> 04.11.2017 10:05, Adam Borowski пишет: >>>> On Sat, Nov 04, 2017 at 09:26:36AM +0300, Andrei Borzenkov wrote: >>>>> 04.11.2017 07:49, Adam Borowski пишет: >>>>>> On Fri, Nov 03, 2017 at 06:15:53PM -0600, Chris Murphy wrote: >>>>>>> Ancient bug, still seems to be a bug. >>>>>>> https://bugzilla.redhat.com/show_bug.cgi?id=906591 >>>>>>> >>>>>>> The issue is that updatedb by default will not index bind mounts, but >>>>>>> by default on Fedora and probably other distros, put /home on a >>>>>>> subvolume and then mount that subvolume which is in effect a bind >>>>>>> mount. >>>>>>> >>>>>>> There's a lot of early discussion in 2013 about it, but then it's >>>>>>> dropped off the radar as nobody has any ideas how to fix this in >>>>>>> mlocate. >>>>>> >>>>>> I don't see how this would be a bug in btrfs. The same happens if you >>>>>> bind-mount /home (or individual homes), which is a valid and non-rare setup. >>>>> >>>>> It is the problem *on* btrfs because - as opposed to normal bind mount - >>>>> those mount points do *not* refer to the same content. >>>> >>>> Neither do they refer to in a "normal" bind mount. >>>> >>>>> As was commented in mentioned bug report: >>>>> >>>>> mount -o subvol=root /dev/sdb1 /root >>>>> mount -o subvol=foo /dev/sdb1 /root/foo >>>>> mount -o subvol bar /dev/sdb1 /bar/bar >>>>> >>>>> Both /root/foo and /root/bar, will be skipped even though they are not >>>>> accessible via any other path (on mounted filesystem) >>>> >>>> losetup -D >>>> truncate -s 4G junk >>>> losetup -f junk >>>> mkfs.ext4 /dev/loop0 >>>> mkdir -p foo bar >>>> mount /dev/loop0 foo >>>> mkdir foo/bar >>>> touch foo/fileA foo/bar/fileB >>>> mount --bind foo/bar bar >>>> umount foo >>>> >>> >>> Indeed. I can build the same configuration on non-btrfs and updatedb >>> would skip non-overlapping mounts just as it would on btrfs. It is just >>> that it is rather more involved on other filesystems (and as you >>> mentioned this requires top-level to be mounted at some point), while on >>> btrfs it is much easier to get (and is default on number of distributions). >>> >>> So yes, it really appears that updatedb check for duplicated mounts is >>> wrong in general and needs rethinking. >> >> Yes, even if it's not a Btrfs bug, I think it's useful to get a >> different set of eyes on this than just the mlocate folks. Maybe it >> should get posted to fs-devel? >> > > Looking at mlocate history, initial bind detection was extremely > simplistic but actually correct, and would still work even with btrfs - > just look in /etc/mtab for mount with "bind" option where what != where. > This covers any sort of bind mount. > > Later /etc/mtab disappeared and code was rewritten to use mountinfo. > Intentionally or not, this rewrite only works for bind mounts inside the > same filesystem subtree. I.e. it also won't catch cross filesystem bind > mounts. Failure on btrfs is side effect of this assumption. This brings to mind another 'feature' of BTRFS that I came across recently, namely that subvolumes that aren't explicitly mounted still show up as mount points according to how most CLI tools differentiate what's a mount point. In particular, the st_dev field in stat() results for the subvolume differs from the containing directory, and the f_fsid field in statvfs() results for the subvolume differs from the containing directory (a side effect of the differing st_dev field, which is part of what's used to calculate f_fsid on Linux), which means the only way to know if something actually is a mount point is to make this check, and then verify it in /proc/mounts or /proc/self/mountinfo. That particular 'feature' means that GNU find, xargs, and du will never cross subvolume boundaries if you tell them to stay on one filesystem, and some other tools may misidentify where things are mounted. > > So it actually can be considered regression in mlocate code. > > I suppose first mlocate folks need to get clear answer what they want to > test here, then it makes sense to discuss how to do it. Agreed.
next prev parent reply other threads:[~2017-11-06 13:51 UTC|newest] Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-11-04 0:15 Chris Murphy 2017-11-04 4:49 ` Adam Borowski 2017-11-04 6:26 ` Andrei Borzenkov 2017-11-04 7:05 ` Adam Borowski 2017-11-04 18:27 ` Andrei Borzenkov 2017-11-04 18:55 ` Chris Murphy 2017-11-04 19:37 ` Nicholas D Steeves 2017-11-05 8:01 ` Andrei Borzenkov 2017-11-06 13:51 ` Austin S. Hemmelgarn [this message] 2017-11-06 18:35 ` Chris Murphy 2017-11-06 19:44 ` Austin S. Hemmelgarn 2017-11-05 7:47 ` Fixed subject: updatedb does not index separately mounted btrfs subvolumes Duncan 2017-11-05 14:02 ` Chris Murphy 2017-11-06 0:27 ` Peter Grandi
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --subject='Re: updatedb does not index /home when /home is Btrfs' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).