From: Anand Jain <anand.jain@oracle.com>
To: Nikolay Borisov <nborisov@suse.com>, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 1/7] btrfs: Remove inode argument from async_cow_submit
Date: Sat, 5 Jan 2019 14:02:15 +0800 [thread overview]
Message-ID: <79855009-a86f-c055-56d1-2ee06e9efbc5@oracle.com> (raw)
In-Reply-To: <20190103085005.32053-2-nborisov@suse.com>
On 01/03/2019 04:49 PM, Nikolay Borisov wrote:
> We already pass the async_cow struct that holds a reference to the
> inode. Exploit this fact and remove the extra inode argument. No
> functional changes.
>
> Signed-off-by: Nikolay Borisov <nborisov@suse.com>
Reviewed-by: Anand Jain <anand.jain@oracle.com>
> ---
> fs/btrfs/inode.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/fs/btrfs/inode.c b/fs/btrfs/inode.c
> index 38c0f385a617..43baca50fba5 100644
> --- a/fs/btrfs/inode.c
> +++ b/fs/btrfs/inode.c
> @@ -714,9 +714,9 @@ static void free_async_extent_pages(struct async_extent *async_extent)
> * queued. We walk all the async extents created by compress_file_range
> * and send them down to the disk.
> */
> -static noinline void submit_compressed_extents(struct inode *inode,
> - struct async_cow *async_cow)
> +static noinline void submit_compressed_extents(struct async_cow *async_cow)
> {
> + struct inode *inode = async_cow->inode;
> struct btrfs_fs_info *fs_info = btrfs_sb(inode->i_sb);
> struct async_extent *async_extent;
> u64 alloc_hint = 0;
> @@ -1167,7 +1167,7 @@ static noinline void async_cow_submit(struct btrfs_work *work)
> cond_wake_up_nomb(&fs_info->async_submit_wait);
>
> if (async_cow->inode)
> - submit_compressed_extents(async_cow->inode, async_cow);
> + submit_compressed_extents(async_cow);
> }
>
> static noinline void async_cow_free(struct btrfs_work *work)
>
next prev parent reply other threads:[~2019-01-05 6:03 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-03 8:49 [PATCH 0/7] More misc fixes Nikolay Borisov
2019-01-03 8:49 ` [PATCH 1/7] btrfs: Remove inode argument from async_cow_submit Nikolay Borisov
2019-01-05 6:02 ` Anand Jain [this message]
2019-01-07 10:12 ` Johannes Thumshirn
2019-01-03 8:50 ` [PATCH 2/7] btrfs: Remove isize local variable in compress_file_range Nikolay Borisov
2019-01-05 6:17 ` Anand Jain
2019-01-07 10:17 ` Johannes Thumshirn
2019-01-07 17:41 ` David Sterba
2019-01-03 8:50 ` [PATCH 3/7] btrfs: Use ihold instead of igrab in cow_file_range_async Nikolay Borisov
2019-01-04 15:29 ` David Sterba
2019-01-03 8:50 ` [PATCH 4/7] btrfs: Remove WARN_ON in btrfs_alloc_delalloc_work Nikolay Borisov
2019-01-04 15:30 ` David Sterba
2019-01-07 10:19 ` Johannes Thumshirn
2019-01-03 8:50 ` [PATCH 5/7] btrfs: Document logic in async_cow_submit Nikolay Borisov
2019-01-03 8:50 ` [PATCH 6/7] btrfs: Replace open-coded maths with DIV_ROUND_UP Nikolay Borisov
2019-01-03 14:44 ` David Sterba
2019-01-03 15:33 ` Nikolay Borisov
2019-01-07 15:29 ` David Sterba
2019-01-03 8:50 ` [PATCH 7/7] btrfs: Refactor shrink_delalloc Nikolay Borisov
2019-01-04 15:35 ` David Sterba
2019-01-07 17:58 ` David Sterba
2019-01-07 17:59 ` [PATCH 0/7] More misc fixes David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=79855009-a86f-c055-56d1-2ee06e9efbc5@oracle.com \
--to=anand.jain@oracle.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=nborisov@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).