From: Johannes Thumshirn <jthumshirn@suse.de>
To: dsterba@suse.cz, Dmitriy Gorokh <dmitriy.gorokh@gmail.com>,
linux-btrfs@vger.kernel.org, Ming Lei <ming.lei@redhat.com>
Subject: Re: [PATCH v2] btrfs: raid56: data corruption on a device removal
Date: Fri, 11 Jan 2019 09:08:27 +0100 [thread overview]
Message-ID: <7e1204a4-ed81-7989-f479-f1ee9d0dfd64@suse.de> (raw)
In-Reply-To: <be8f867e-deee-ccbd-65c5-e4140fdf7b8c@suse.de>
On 10/01/2019 17:49, Johannes Thumshirn wrote:
> Right, but we're looking for the number of already completed bytes to
> rewind here, so from bvec.h's docs it is bi_bvec_done.
>
> Dmitriy can you see if this works for you:
>
> diff --git a/fs/btrfs/raid56.c b/fs/btrfs/raid56.c
> index e74455eb42f9..2d0e2eec5413 100644
> --- a/fs/btrfs/raid56.c
> +++ b/fs/btrfs/raid56.c
> @@ -1350,6 +1350,7 @@ static int find_bio_stripe(struct btrfs_raid_bio
> *rbio,
> struct btrfs_bio_stripe *stripe;
>
> physical <<= 9;
> + physical -= bio->bi_iter.bi_bvec_done;
OK talked to Hannes about this issue, he says the only way is to save
the iterator state before submitting the bio.
So the above is bogus too.
This also is what Kent said in
https://marc.info/?l=linux-block&m=153549921116441&w=2
--
Johannes Thumshirn SUSE Labs Filesystems
jthumshirn@suse.de +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
next prev parent reply other threads:[~2019-01-11 8:08 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-12 0:25 [PATCH] btrfs: raid56: data corruption on a device removal Dmitriy Gorokh
2018-12-12 9:09 ` Johannes Thumshirn
2018-12-12 15:53 ` David Sterba
2018-12-14 17:48 ` [PATCH v2] " Dmitriy Gorokh
2018-12-26 0:15 ` Liu Bo
2019-01-04 16:49 ` David Sterba
2019-01-07 11:03 ` Johannes Thumshirn
2019-01-07 15:34 ` David Sterba
2019-01-10 16:49 ` Johannes Thumshirn
2019-01-11 8:08 ` Johannes Thumshirn [this message]
2019-01-11 9:26 ` Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7e1204a4-ed81-7989-f479-f1ee9d0dfd64@suse.de \
--to=jthumshirn@suse.de \
--cc=dmitriy.gorokh@gmail.com \
--cc=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
--cc=ming.lei@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).