From: Nikolay Borisov <nborisov@suse.com>
To: dsterba@suse.cz, Qu Wenruo <wqu@suse.com>, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH v2 3/4] btrfs: introduce btrfs_subpage_bitmap_info
Date: Mon, 30 Aug 2021 17:28:42 +0300 [thread overview]
Message-ID: <7f090871-17c5-cad2-b30a-807ff8509d1d@suse.com> (raw)
In-Reply-To: <20210823164540.GG5047@twin.jikos.cz>
On 23.08.21 г. 19:45, David Sterba wrote:
> On Tue, Aug 17, 2021 at 01:11:43PM +0300, Nikolay Borisov wrote:
>>> +/*
>>> + * Extra info for subpapge bitmap.
>>> + *
>>> + * For subpage we pack all uptodate/error/dirty/writeback/ordered
>>> + * bitmaps into one larger bitmap.
>>> + *
>>> + * This structure records how they are organized in such bitmap:
>>> + *
>>> + * /- uptodate_offset /- error_offset /- dirty_offset
>>> + * | | |
>>> + * v v v
>>> + * |u|u|u|u|........|u|u|e|e|.......|e|e| ... |o|o|
>>
>> nit: the 'e' that the dirty offset is pointing to should be a 'd', I'm
>> sure David can fix this while merging.
>
> I don't see any 'e' under the dirty offset arrow, there's just 'o' and
> the arrow points to end of |e|e| and continues with ...
>
What I wanted to say is that every arrow beneat the respective type -
uptodate/error/dirty should point to a letter corresponding to the first
letter of the respective word. I.e the dirty offset points into ...
whilst the |o|o| at the end likely mean "other" but is confusing i.e
dirty offset should be pointing to a |d| box.
next prev parent reply other threads:[~2021-08-30 14:28 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-17 9:38 [PATCH v2 0/2] btrfs: subpage: pack all subpage bitmaps into a larger bitmap Qu Wenruo
2021-08-17 9:38 ` [PATCH v2 1/4] btrfs: only call btrfs_alloc_subpage() when sectorsize is smaller than PAGE_SIZE Qu Wenruo
2021-08-17 9:38 ` [PATCH v2 2/4] btrfs: make btrfs_alloc_subpage() to return struct btrfs_subpage * directly Qu Wenruo
2021-08-17 9:38 ` [PATCH v2 3/4] btrfs: introduce btrfs_subpage_bitmap_info Qu Wenruo
2021-08-17 10:11 ` Nikolay Borisov
2021-08-23 16:45 ` David Sterba
2021-08-30 14:28 ` Nikolay Borisov [this message]
2021-08-23 16:41 ` David Sterba
2021-08-23 23:15 ` Qu Wenruo
2021-08-17 9:38 ` [PATCH v2 4/4] btrfs: subpage: pack all subpage bitmaps into a larger bitmap Qu Wenruo
2021-08-17 13:43 ` Nikolay Borisov
2021-08-23 17:00 ` David Sterba
2021-08-23 16:57 ` David Sterba
2021-08-23 23:16 ` Qu Wenruo
2021-08-24 14:20 ` David Sterba
2021-08-17 13:44 ` [PATCH v2 0/2] " Nikolay Borisov
2021-08-23 17:05 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7f090871-17c5-cad2-b30a-807ff8509d1d@suse.com \
--to=nborisov@suse.com \
--cc=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).