linux-btrfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ritesh Harjani <riteshh@linux.ibm.com>
To: fstests@vger.kernel.org
Cc: anju@linux.vnet.ibm.com, Eryu Guan <guan@eryu.me>,
	linux-ext4@vger.kernel.org, linux-btrfs@vger.kernel.org,
	linux-xfs@vger.kernel.org, Ritesh Harjani <riteshh@linux.ibm.com>
Subject: [PATCH 3/3] common/rc: source common/xfs and common/btrfs
Date: Fri, 30 Oct 2020 01:22:53 +0530	[thread overview]
Message-ID: <8d7db41971a227c5bd83677464d139399607e720.1604000570.git.riteshh@linux.ibm.com> (raw)
In-Reply-To: <cover.1604000570.git.riteshh@linux.ibm.com>

Without this patch I am unable to test for multiple different
filesystem sections for the same tests. Since we anyway have only
function definitions in these files, so it should be ok to source it
by default too.
e.g. when I run ./check -s btrfs tests/generic/613 with 3 different [***_fs]
sections from local.config file, I see below failures.

./common/rc: line 2801: _check_btrfs_filesystem: command not found

./check -s xfs_4k -g swap (for XFS this fails like below)
./common/rc: line 749: _scratch_mkfs_xfs: command not found
check: failed to mkfs $SCRATCH_DEV using specified options

Signed-off-by: Ritesh Harjani <riteshh@linux.ibm.com>
---
 common/rc | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/common/rc b/common/rc
index 4c59968a6bd3..e9ba1b6e8265 100644
--- a/common/rc
+++ b/common/rc
@@ -3,6 +3,8 @@
 # Copyright (c) 2000-2006 Silicon Graphics, Inc.  All Rights Reserved.
 
 . common/config
+. ./common/xfs
+. ./common/btrfs
 
 BC=$(which bc 2> /dev/null) || BC=
 
-- 
2.26.2


  parent reply	other threads:[~2020-10-29 19:53 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-29 19:52 [PATCH 0/3] fstests: Fix tests which checks for swapfile support Ritesh Harjani
2020-10-29 19:52 ` [PATCH 1/3] common/rc: Make swapon check in _require_scratch_swapfile() specific to btrfs Ritesh Harjani
2020-10-30 13:18   ` Brian Foster
2020-10-29 19:52 ` [PATCH 2/3] shared/001: Verify swapon on fallocated files for supported FS Ritesh Harjani
2020-10-30 13:19   ` Brian Foster
2020-10-29 19:52 ` Ritesh Harjani [this message]
2020-10-29 21:04   ` [PATCH 3/3] common/rc: source common/xfs and common/btrfs Darrick J. Wong
2020-11-01 16:03 ` [PATCH 0/3] fstests: Fix tests which checks for swapfile support Eryu Guan
2020-11-26  3:51   ` Ritesh Harjani

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8d7db41971a227c5bd83677464d139399607e720.1604000570.git.riteshh@linux.ibm.com \
    --to=riteshh@linux.ibm.com \
    --cc=anju@linux.vnet.ibm.com \
    --cc=fstests@vger.kernel.org \
    --cc=guan@eryu.me \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-xfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).