From: Anand Jain <anand.jain@oracle.com>
To: dsterba@suse.cz, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH v1.1 04/18] btrfs-progs: add global verbose and quiet options and helper functions
Date: Mon, 25 Nov 2019 18:36:53 +0800 [thread overview]
Message-ID: <8e4e8164-ac80-bc2f-0196-1f86570c2e47@oracle.com> (raw)
In-Reply-To: <20191119165147.GW3001@twin.jikos.cz>
On 11/20/19 12:51 AM, David Sterba wrote:
> On Tue, Nov 19, 2019 at 11:36:59AM +0800, Anand Jain wrote:
>>> As this is a simple fixup
>>> s/HELPINFO_GLOBAL_OPTIONS_HEADER/HELPINFO_INSERT_GLOBALS/, hold on with
>>> resending I might find more things or fix it myself.
>>>
>>
>> But there is one problem, HELPINFO_INSERT_GLOBALS is already defined
>> as..
>> Global options:
>> --format TYPE where TYPE is: text
>>
>> (ref: common/help.c do_usage_one_command())
>>
>> Albeit all commands support --format text by default.
>>
>> But no sub-command is using the HELPINFO_INSERT_GLOBALS in its usage.
>>
>> Looks like its a good idea to separate title and the options, like
>> #define HELPINFO_INSERT_GLOBALS "Global options:"
>> #define HELPINGO_INSERT_FORMAT "--format TYPE"
>
> Yeah, makes sense to split it, right now the format does not bring
> anything so that will be better done in a major release some time in the
> future when more commands have json output.
Ok. In v2 I have split
HELPINFO_GLOBAL_OPTIONS_HEADER into HELPINFO_INSERT_GLOBALS and
HELPINGO_INSERT_FORMAT as above.
Thanks, Anand
>> As at the moment I am not sure if its safe to declare that all
>> sub-commands will support --format json (whenever we do that).
>
> No, right now json output should not be declared anywhere.
>
>> So with the defines split as above, in each sub-command-usage
>> we shall do..
>>
>> -----------------------------------------
>> diff --git a/cmds/filesystem.c b/cmds/filesystem.c
>> index 4f22089abeaa..f4dba38b4c17 100644
>> --- a/cmds/filesystem.c
>> +++ b/cmds/filesystem.c
>> @@ -631,6 +631,10 @@ static const char * const
>> cmd_filesystem_show_usage[] = {
>> "-m|--mounted show only mounted btrfs",
>> HELPINFO_UNITS_LONG,
>> "If no argument is given, structure of all present filesystems
>> is shown.",
>> + HELPINFO_INSERT_GLOBALS,
>> + HELPINFO_INSERT_FORMAT,
>> + HELPINFO_INSERT_VERBOSE,
>> + HELPINFO_INSERT_QUIET,
>
> Sounds ok.
>
next prev parent reply other threads:[~2019-11-25 10:37 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-04 6:32 [PATCH v1.1 00/18] btrfs-progs: global verbose and quiet option Anand Jain
2019-11-04 6:32 ` [PATCH v1 01/18] btrfs-progs: receive: fix option quiet Anand Jain
2019-11-04 6:33 ` [PATCH v1 02/18] btrfs-progs: balance status: fix usage show long verbose Anand Jain
2019-11-04 6:33 ` [PATCH v1 03/18] btrfs-progs: balance start: fix usage add " Anand Jain
2019-11-04 6:33 ` [PATCH v1.1 04/18] btrfs-progs: add global verbose and quiet options and helper functions Anand Jain
2019-11-14 16:08 ` David Sterba
2019-11-19 2:44 ` Anand Jain
2019-11-19 3:36 ` Anand Jain
2019-11-19 16:51 ` David Sterba
2019-11-25 10:36 ` Anand Jain [this message]
2019-11-15 15:58 ` David Sterba
2019-11-19 5:07 ` Anand Jain
2019-11-19 17:02 ` David Sterba
2019-11-04 6:33 ` [PATCH v1.1 05/18] btrfs-progs: send: use global verbose and quiet options Anand Jain
2019-11-04 6:33 ` [PATCH v1.1 06/18] btrfs-progs: receive: " Anand Jain
2019-11-04 6:33 ` [PATCH v1.1 07/18] btrfs-progs: subvolume delete: use global verbose option Anand Jain
2019-11-04 6:33 ` [PATCH v1 08/18] btrfs-progs: filesystem defragment: " Anand Jain
2019-11-14 16:16 ` David Sterba
2019-11-25 10:35 ` Anand Jain
2019-11-04 6:33 ` [PATCH v1 09/18] btrfs-progs: balance start: " Anand Jain
2019-11-04 6:33 ` [PATCH v1 10/18] btrfs-progs: balance status: " Anand Jain
2019-11-04 6:33 ` [PATCH v1 11/18] btrfs-progs: rescue chunk-recover: " Anand Jain
2019-11-04 6:33 ` [PATCH v1 12/18] btrfs-progs: rescue super-recover: " Anand Jain
2019-11-04 6:33 ` [PATCH v1.1 13/18] btrfs-progs: restore: " Anand Jain
2019-11-04 6:33 ` [PATCH v1 14/18] btrfs-progs: inspect-internal inode-resolve: use global verbose Anand Jain
2019-11-04 6:33 ` [PATCH v1 15/18] btrfs-progs: inspect-internal logical-resolve: use global verbose option Anand Jain
2019-11-04 6:33 ` [PATCH v1.1 16/18] btrfs-progs: refactor btrfs_scan_devices() to accept verbose argument Anand Jain
2019-11-04 6:33 ` [PATCH v1 17/18] btrfs-progs: device scan: add verbose option Anand Jain
2019-11-04 6:33 ` [PATCH v1.1 18/18] btrfs-progs: device scan: add quiet option Anand Jain
2019-11-15 16:11 ` [PATCH v1.1 00/18] btrfs-progs: global verbose and " David Sterba
2019-11-19 3:50 ` Anand Jain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8e4e8164-ac80-bc2f-0196-1f86570c2e47@oracle.com \
--to=anand.jain@oracle.com \
--cc=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).