From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.9 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6A97BC433E2 for ; Thu, 3 Sep 2020 10:09:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2441A20767 for ; Thu, 3 Sep 2020 10:09:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726368AbgICKJI (ORCPT ); Thu, 3 Sep 2020 06:09:08 -0400 Received: from mx2.suse.de ([195.135.220.15]:45804 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725984AbgICKJF (ORCPT ); Thu, 3 Sep 2020 06:09:05 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id DD07EAD3C; Thu, 3 Sep 2020 10:09:04 +0000 (UTC) Subject: Re: [PATCH 02/15] btrfs: add btrfs_sysfs_remove_device helper To: Anand Jain , linux-btrfs@vger.kernel.org References: <3e4180cf-c43d-baa1-db94-2d5d6c8965ca@suse.com> From: Nikolay Borisov Autocrypt: addr=nborisov@suse.com; prefer-encrypt=mutual; keydata= xsFNBFiKBz4BEADNHZmqwhuN6EAzXj9SpPpH/nSSP8YgfwoOqwrP+JR4pIqRK0AWWeWCSwmZ T7g+RbfPFlmQp+EwFWOtABXlKC54zgSf+uulGwx5JAUFVUIRBmnHOYi/lUiE0yhpnb1KCA7f u/W+DkwGerXqhhe9TvQoGwgCKNfzFPZoM+gZrm+kWv03QLUCr210n4cwaCPJ0Nr9Z3c582xc bCUVbsjt7BN0CFa2BByulrx5xD9sDAYIqfLCcZetAqsTRGxM7LD0kh5WlKzOeAXj5r8DOrU2 GdZS33uKZI/kZJZVytSmZpswDsKhnGzRN1BANGP8sC+WD4eRXajOmNh2HL4P+meO1TlM3GLl EQd2shHFY0qjEo7wxKZI1RyZZ5AgJnSmehrPCyuIyVY210CbMaIKHUIsTqRgY5GaNME24w7h TyyVCy2qAM8fLJ4Vw5bycM/u5xfWm7gyTb9V1TkZ3o1MTrEsrcqFiRrBY94Rs0oQkZvunqia c+NprYSaOG1Cta14o94eMH271Kka/reEwSZkC7T+o9hZ4zi2CcLcY0DXj0qdId7vUKSJjEep c++s8ncFekh1MPhkOgNj8pk17OAESanmDwksmzh1j12lgA5lTFPrJeRNu6/isC2zyZhTwMWs k3LkcTa8ZXxh0RfWAqgx/ogKPk4ZxOXQEZetkEyTFghbRH2BIwARAQABzSJOaWtvbGF5IEJv cmlzb3YgPG5ib3Jpc292QHN1c2UuZGU+wsF4BBMBAgAiBQJYijkSAhsDBgsJCAcDAgYVCAIJ CgsEFgIDAQIeAQIXgAAKCRBxvoJG5T8oV/B6D/9a8EcRPdHg8uLEPywuJR8URwXzkofT5bZE IfGF0Z+Lt2ADe+nLOXrwKsamhweUFAvwEUxxnndovRLPOpWerTOAl47lxad08080jXnGfYFS Dc+ew7C3SFI4tFFHln8Y22Q9075saZ2yQS1ywJy+TFPADIprAZXnPbbbNbGtJLoq0LTiESnD w/SUC6sfikYwGRS94Dc9qO4nWyEvBK3Ql8NkoY0Sjky3B0vL572Gq0ytILDDGYuZVo4alUs8 LeXS5ukoZIw1QYXVstDJQnYjFxYgoQ5uGVi4t7FsFM/6ykYDzbIPNOx49Rbh9W4uKsLVhTzG BDTzdvX4ARl9La2kCQIjjWRg+XGuBM5rxT/NaTS78PXjhqWNYlGc5OhO0l8e5DIS2tXwYMDY LuHYNkkpMFksBslldvNttSNei7xr5VwjVqW4vASk2Aak5AleXZS+xIq2FADPS/XSgIaepyTV tkfnyreep1pk09cjfXY4A7qpEFwazCRZg9LLvYVc2M2eFQHDMtXsH59nOMstXx2OtNMcx5p8 0a5FHXE/HoXz3p9bD0uIUq6p04VYOHsMasHqHPbsMAq9V2OCytJQPWwe46bBjYZCOwG0+x58 fBFreP/NiJNeTQPOa6FoxLOLXMuVtpbcXIqKQDoEte9aMpoj9L24f60G4q+pL/54ql2VRscK d87BTQRYigc+ARAAyJSq9EFk28++SLfg791xOh28tLI6Yr8wwEOvM3wKeTfTZd+caVb9gBBy wxYhIopKlK1zq2YP7ZjTP1aPJGoWvcQZ8fVFdK/1nW+Z8/NTjaOx1mfrrtTGtFxVBdSCgqBB jHTnlDYV1R5plJqK+ggEP1a0mr/rpQ9dFGvgf/5jkVpRnH6BY0aYFPprRL8ZCcdv2DeeicOO YMobD5g7g/poQzHLLeT0+y1qiLIFefNABLN06Lf0GBZC5l8hCM3Rpb4ObyQ4B9PmL/KTn2FV Xq/c0scGMdXD2QeWLePC+yLMhf1fZby1vVJ59pXGq+o7XXfYA7xX0JsTUNxVPx/MgK8aLjYW hX+TRA4bCr4uYt/S3ThDRywSX6Hr1lyp4FJBwgyb8iv42it8KvoeOsHqVbuCIGRCXqGGiaeX Wa0M/oxN1vJjMSIEVzBAPi16tztL/wQtFHJtZAdCnuzFAz8ue6GzvsyBj97pzkBVacwp3/Mw qbiu7sDz7yB0d7J2tFBJYNpVt/Lce6nQhrvon0VqiWeMHxgtQ4k92Eja9u80JDaKnHDdjdwq FUikZirB28UiLPQV6PvCckgIiukmz/5ctAfKpyYRGfez+JbAGl6iCvHYt/wAZ7Oqe/3Cirs5 KhaXBcMmJR1qo8QH8eYZ+qhFE3bSPH446+5oEw8A9v5oonKV7zMAEQEAAcLBXwQYAQIACQUC WIoHPgIbDAAKCRBxvoJG5T8oV1pyD/4zdXdOL0lhkSIjJWGqz7Idvo0wjVHSSQCbOwZDWNTN JBTP0BUxHpPu/Z8gRNNP9/k6i63T4eL1xjy4umTwJaej1X15H8Hsh+zakADyWHadbjcUXCkg OJK4NsfqhMuaIYIHbToi9K5pAKnV953xTrK6oYVyd/Rmkmb+wgsbYQJ0Ur1Ficwhp6qU1CaJ mJwFjaWaVgUERoxcejL4ruds66LM9Z1Qqgoer62ZneID6ovmzpCWbi2sfbz98+kW46aA/w8r 7sulgs1KXWhBSv5aWqKU8C4twKjlV2XsztUUsyrjHFj91j31pnHRklBgXHTD/pSRsN0UvM26 lPs0g3ryVlG5wiZ9+JbI3sKMfbdfdOeLxtL25ujs443rw1s/PVghphoeadVAKMPINeRCgoJH zZV/2Z/myWPRWWl/79amy/9MfxffZqO9rfugRBORY0ywPHLDdo9Kmzoxoxp9w3uTrTLZaT9M KIuxEcV8wcVjr+Wr9zRl06waOCkgrQbTPp631hToxo+4rA1jiQF2M80HAet65ytBVR2pFGZF zGYYLqiG+mpUZ+FPjxk9kpkRYz61mTLSY7tuFljExfJWMGfgSg1OxfLV631jV1TcdUnx+h3l Sqs2vMhAVt14zT8mpIuu2VNxcontxgVr1kzYA/tQg32fVRbGr449j1gw57BV9i0vww== Message-ID: <8f014715-ff3b-57d4-a45d-b3544aa07edb@suse.com> Date: Thu, 3 Sep 2020 13:09:02 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-btrfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org On 3.09.20 г. 13:03 ч., Anand Jain wrote: > > > On 3/9/20 4:44 pm, Nikolay Borisov wrote: >> >> >> On 3.09.20 г. 3:57 ч., Anand Jain wrote: >>> btrfs_sysfs_remove_devices_dir() removes device link and devid kobject >>> (sysfs entries) for a device or all the devices in the btrfs_fs_devices. >>> In preparation to remove these sysfs entries for the seed as well, add >>> a btrfs_sysfs_remove_device() helper function and avoid code >>> duplication. >>> >>> Signed-off-by: Anand Jain >> >> LGTM, one nit below though: >> >> Reviewed-by: Nikolay Borisov >> >>> --- >>>   fs/btrfs/sysfs.c | 54 ++++++++++++++++++++++-------------------------- >>>   1 file changed, 25 insertions(+), 29 deletions(-) >>> >>> diff --git a/fs/btrfs/sysfs.c b/fs/btrfs/sysfs.c >>> index 3381a91d7deb..241ec0ad0379 100644 >>> --- a/fs/btrfs/sysfs.c >>> +++ b/fs/btrfs/sysfs.c >>> @@ -1149,46 +1149,42 @@ int btrfs_sysfs_add_space_info_type(struct >>> btrfs_fs_info *fs_info, >>>       return 0; >>>   } >>>   -/* when one_device is NULL, it removes all device links */ >>> - >>> -int btrfs_sysfs_remove_devices_dir(struct btrfs_fs_devices *fs_devices, >>> -        struct btrfs_device *one_device) >>> +static void btrfs_sysfs_remove_device(struct btrfs_device *device) >>>   { >>>       struct hd_struct *disk; >>>       struct kobject *disk_kobj; >>> +    struct kobject *devices_kobj; >>>   -    if (!fs_devices->devices_kobj) >>> -        return -EINVAL; >>> +    /* >>> +     * Seed fs_devices devices_kobj aren't used, fetch kobject from the >>> +     * fs_info::fs_devices. >>> +     */ >>> +    devices_kobj = device->fs_info->fs_devices->devices_kobj; >> >> nit: device->fs_info->fs_devices > >  Sorry what are you suggesting here? I didn't understand. Ah, nothing, you already done it the way I suggested. > > Thanks, Anand > > > >> >>> +    ASSERT(devices_kobj); >>>   -    if (one_device) { >>> -        if (one_device->bdev) { >>> -            disk = one_device->bdev->bd_part; >>> -            disk_kobj = &part_to_dev(disk)->kobj; >>> -            sysfs_remove_link(fs_devices->devices_kobj, >>> -                      disk_kobj->name); >>> -        } >>> +    if (device->bdev) { >>> +        disk = device->bdev->bd_part; >>> +        disk_kobj = &part_to_dev(disk)->kobj; >>> +        sysfs_remove_link(devices_kobj, disk_kobj->name); >>> +    } >>>   -        kobject_del(&one_device->devid_kobj); >>> -        kobject_put(&one_device->devid_kobj); >>> +    kobject_del(&device->devid_kobj); >>> +    kobject_put(&device->devid_kobj); >>>   -        wait_for_completion(&one_device->kobj_unregister); >>> +    wait_for_completion(&device->kobj_unregister); >>> +} >>>   +/* when 2nd argument device is NULL, it removes all devices link */ >>> +int btrfs_sysfs_remove_devices_dir(struct btrfs_fs_devices *fs_devices, >>> +                   struct btrfs_device *one_device) >>> +{ >>> +    if (one_device) { >>> +        btrfs_sysfs_remove_device(one_device); >>>           return 0; >>>       } >>>   -    list_for_each_entry(one_device, &fs_devices->devices, dev_list) { >>> - >>> -        if (one_device->bdev) { >>> -            disk = one_device->bdev->bd_part; >>> -            disk_kobj = &part_to_dev(disk)->kobj; >>> -            sysfs_remove_link(fs_devices->devices_kobj, >>> -                      disk_kobj->name); >>> -        } >>> -        kobject_del(&one_device->devid_kobj); >>> -        kobject_put(&one_device->devid_kobj); >>> - >>> -        wait_for_completion(&one_device->kobj_unregister); >>> -    } >>> +    list_for_each_entry(one_device, &fs_devices->devices, dev_list) >>> +        btrfs_sysfs_remove_device(one_device); >>>         return 0; >>>   } >>> >