Re: [PATCH] btrfs: tree-checker: dump the page status if hit something wrong

[Tavian Barnes <tavianator@tavianator.com>]

On Tue, Feb 6, 2024 at 4:48 PM Tavian Barnes <tavianator@tavianator.com> wrote:
> I just tried the tip of btrfs/for-next (6a1dc34172e0, "btrfs: move
> transaction abort to the error site btrfs_rebuild_free_space_tree()"),
> plus the dump_page() patch

By the way Qu, you should fold

@@ -2036,6 +2042,7 @@ int btrfs_check_eb_owner(const struct
extent_buffer *eb, u64 root_owner)
        if (!is_subvol) {
                /* For non-subvolume trees, the eb owner should match
root owner */
                if (unlikely(root_owner != eb_owner)) {
+                       dump_page(folio_page(eb->folios[0], 0), "eb page dump");
                        btrfs_crit(eb->fs_info,
 "corrupted %s, root=%llu block=%llu owner mismatch, have %llu expect %llu",
                                btrfs_header_level(eb) == 0 ? "leaf" : "node",
@@ -2051,6 +2058,7 @@ int btrfs_check_eb_owner(const struct
extent_buffer *eb, u64 root_owner)
         * to subvolume trees.
         */
        if (unlikely(is_subvol != is_fstree(eb_owner))) {
+               dump_page(folio_page(eb->folios[0], 0), "eb page dump");
                btrfs_crit(eb->fs_info,
 "corrupted %s, root=%llu block=%llu owner mismatch, have %llu expect
[%llu, %llu]",
                        btrfs_header_level(eb) == 0 ? "leaf" : "node",

into the patch.  Right now it's missing the dump_page() for the
relevant error message.

-- 
Tavian Barnes