linux-btrfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Klara Modin <klarasmodin@gmail.com>
To: wqu@suse.com
Cc: linux-btrfs@vger.kernel.org, terrelln@fb.com, dsterba@suse.com,
	 josef@toxicpanda.com, clm@fb.com
Subject: Re: [PATCH 3/3] btrfs: zstd: fix and simplify the inline extent decompression
Date: Mon, 22 Jan 2024 21:45:42 +0100	[thread overview]
Message-ID: <CABq1_vj4GpUeZpVG49OHCo-3sdbe2-2ROcu_xDvUG-6-5zPRXg@mail.gmail.com> (raw)

Hi,

With this patch [1], small zstd compressed files on btrfs return
garbage when read on my x86_64 system. Reverting this on top of
next-20240122 resolves the issue for me.

From what I can see so far it only directly affects zstd and not zlib
or lzo (with their respective patches) and only when it fits within
the page size. Larger files don't seem to be affected (and does not
trigger my breakpoint on zstd_decompress).

Note that if the files are defragmented, the garbage data seems to be
used (this triggers the breakpoint on zstd_decompress) which makes it
permanent.

This patch seems to be queued for 6.8-rc2.

Please tell me if there's anything else you need.

Kind regards,
Klara Modin

[1]: https://lore.kernel.org/all/0e4ae269b3fd0caf99964c16c98bdd67dbab7150.1704704328.git.wqu@suse.com/

             reply	other threads:[~2024-01-22 20:45 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-22 20:45 Klara Modin [this message]
2024-01-22 20:59 ` [PATCH 3/3] btrfs: zstd: fix and simplify the inline extent decompression David Sterba
2024-01-22 23:54   ` David Sterba
2024-01-23 10:50     ` Klara Modin
  -- strict thread matches above, loose matches on Subject: below --
2024-01-08  9:08 [PATCH 0/3] btrfs: fix and simplify the inline extent decompression path for subpage Qu Wenruo
2024-01-08  9:08 ` [PATCH 3/3] btrfs: zstd: fix and simplify the inline extent decompression Qu Wenruo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CABq1_vj4GpUeZpVG49OHCo-3sdbe2-2ROcu_xDvUG-6-5zPRXg@mail.gmail.com \
    --to=klarasmodin@gmail.com \
    --cc=clm@fb.com \
    --cc=dsterba@suse.com \
    --cc=josef@toxicpanda.com \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=terrelln@fb.com \
    --cc=wqu@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).