Re: [RFC PATCH v2 0/1] Enforce 4k sectorize by default for mkfs

From: Neal Gompa <neal@gompa.dev>
To: Josef Bacik <josef@toxicpanda.com>
Cc: Linux BTRFS Development <linux-btrfs@vger.kernel.org>,
	Anand Jain <anand.jain@oracle.com>,
	Qu Wenruo <quwenruo.btrfs@gmx.com>, Qu Wenruo <wqu@suse.com>,
	David Sterba <dsterba@suse.cz>, Hector Martin <marcan@marcan.st>,
	Sven Peter <sven@svenpeter.dev>,
	Davide Cavalca <davide@cavalca.name>, Jens Axboe <axboe@fb.com>,
	Asahi Lina <lina@asahilina.net>,
	Asahi Linux <asahi@lists.linux.dev>
Subject: Re: [RFC PATCH v2 0/1] Enforce 4k sectorize by default for mkfs
Date: Wed, 22 Mar 2023 13:11:01 -0400	[thread overview]
Message-ID: <CAEg-Je_YvwLSgx-WNmMQTh2EzOn+HYFbBYzhcBygM1UPSrSwew@mail.gmail.com> (raw)
In-Reply-To: <20230322143338.GB2169647@perftesting>

On Wed, Mar 22, 2023 at 10:33 AM Josef Bacik <josef@toxicpanda.com> wrote:
>
> On Tue, Mar 21, 2023 at 02:06:09PM -0400, Neal Gompa wrote:
> > The Fedora Asahi SIG[0] is working on bringing up support for
> > Apple Silicon Macintosh computers through the Asahi Fedora Remix[1].
> >
> > Apple Silicon Macs are unusual in that they currently require 16k
> > page sizes, which means that the current default for mkfs.btrfs(8)
> > makes a filesystem that is unreadable on x86 PCs and most other ARM
> > PCs.
> >
> > Soon, this will be even more of a problem within Apple Silicon Macs
> > as Asahi Lina is working on 4k support to enable x86 emulation[2]
> > and since Linux does not support dynamically switching page sizes at
> > runtime, users will likely regularly switch back and forth depending
> > on their needs.
> >
> > Thus, I'd like to see us finally make the switchover to 4k sectorsize
> > for new filesystems by default, regardless of page size.
> >
> > The initial test run by Hector Martin[3] at request of Qu Wenruo
> > looks promising[4], and I hope we can get this to land upstream soon.
> >
> > This is an update on the initial RFC patch[5], which addresses the
> > documentation feedback from Anand Jain.
> >
> > [0]: https://fedoraproject.org/wiki/SIGs/Asahi
> > [1]: https://asahi-fedora-remix.org/
> > [2]: https://vt.social/@lina/110060963422545117
> > [3]: https://lore.kernel.org/linux-btrfs/fdffeecd-964f-0c69-f869-eb9ceca20263@suse.com/T/#m11d7939de96c43b3a7cdabc7c568d8bcafc7ca83
> > [4]: https://lore.kernel.org/linux-btrfs/fdffeecd-964f-0c69-f869-eb9ceca20263@suse.com/T/#mf382b78a8122b0cb82147a536c85b6a9098a2895
> > [5]: https://lore.kernel.org/linux-btrfs/fdffeecd-964f-0c69-f869-eb9ceca20263@suse.com/T/#t
> >
>
> This all looks good to me, you can add
>
> Reviewed-by: Josef Bacik <josef@toxicpanda.com>
>
> I've got a mac studio on the way, I'll add this to our CI testing to make sure
> we've got good coverage of this code going forward.  Thanks,
>

Since we've got three Reviewed-by tags (you, Qu, and Anand), do I need
to send another version of this to land or can this land as-is?

-- 
真実はいつも一つ！/ Always, there's only one truth!