linux-btrfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Vladimir Panteleev <git@thecybershadow.net>
To: dsterba@suse.cz, Btrfs BTRFS <linux-btrfs@vger.kernel.org>
Subject: Re: [PATCH 1/1] btrfs: Simplify parsing max_inline mount option
Date: Wed, 21 Aug 2019 15:16:11 +0000	[thread overview]
Message-ID: <CAHhfkvw47KtGgFRbqRQriPe6C-qaFDVZPDZhZNafdA8QdKGKjA@mail.gmail.com> (raw)
In-Reply-To: <20190821143526.GJ18575@twin.jikos.cz>

On Wed, 21 Aug 2019 at 14:35, David Sterba <dsterba@suse.cz> wrote:
> match_strdup takes an opaque type
> substring_t that is used by the parser.

Sorry, how would one determine that the type is opaque?

> I've checked some other
> usages in the tree and the match_strdup/memparse/kstrtoull is quite
> common.

Sorry, I also see there are places where substring_t's .from / .to are
still accessed directly (including in btrfs code). Do you think they
ought to use match_strdup instead?

  reply	other threads:[~2019-08-21 15:16 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-15  2:04 [PATCH 0/1] btrfs: Simplify parsing max_inline mount option Vladimir Panteleev
2019-08-15  2:04 ` [PATCH 1/1] " Vladimir Panteleev
2019-08-15  4:54   ` Anand Jain
2019-08-15 14:54     ` Vladimir Panteleev
2019-08-21 14:35   ` David Sterba
2019-08-21 15:16     ` Vladimir Panteleev [this message]
2019-08-21 16:08       ` David Sterba

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAHhfkvw47KtGgFRbqRQriPe6C-qaFDVZPDZhZNafdA8QdKGKjA@mail.gmail.com \
    --to=git@thecybershadow.net \
    --cc=dsterba@suse.cz \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).