From: Chris Murphy <lists@colorremedies.com>
To: "Austin S. Hemmelgarn" <ahferroin7@gmail.com>
Cc: Marat Khalili <mkh@rqc.ru>,
Chris Murphy <lists@colorremedies.com>,
Dave <davestechshop@gmail.com>,
Linux fs Btrfs <linux-btrfs@vger.kernel.org>,
Fred Van Andel <vanandel@gmail.com>
Subject: Re: Problem with file system
Date: Fri, 3 Nov 2017 16:03:44 -0600 [thread overview]
Message-ID: <CAJCQCtTT7_pfx5yn--We-kq0XWd38H_Lw1Prbmo5ytkTZWapYQ@mail.gmail.com> (raw)
In-Reply-To: <b32358ec-781e-aff6-439b-3fc6fe02a25c@gmail.com>
On Tue, Oct 31, 2017 at 5:28 AM, Austin S. Hemmelgarn
<ahferroin7@gmail.com> wrote:
> If you're running on an SSD (or thinly provisioned storage, or something
> else which supports discards) and have the 'discard' mount option enabled,
> then there is no backup metadata tree (this issue was mentioned on the list
> a while ago, but nobody ever replied),
This is a really good point. I've been running discard mount option
for some time now without problems, in a laptop with Samsung
Electronics Co Ltd NVMe SSD Controller SM951/PM951.
However, just trying btrfs-debug-tree -b on a specific block address
for any of the backup root trees listed in the super, only the current
one returns a valid result. All others fail with checksum errors. And
even the good one fails with checksum errors within seconds as a new
tree is created, the super updated, and Btrfs considers the old root
tree disposable and subject to discard.
So absolutely if I were to have a problem, probably no rollback for
me. This seems to totally obviate a fundamental part of Btrfs design.
because it's already been discarded.
> This is ideally something which should be addressed (we need some sort of
> discard queue for handling in-line discards), but it's not easy to address.
Discard data extents, don't discard metadata extents? Or put them on a
substantial delay.
--
Chris Murphy
next prev parent reply other threads:[~2017-11-03 22:03 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-24 15:27 Problem with file system Fred Van Andel
2017-04-24 17:02 ` Chris Murphy
2017-04-25 4:05 ` Duncan
2017-04-25 0:26 ` Qu Wenruo
2017-04-25 5:33 ` Marat Khalili
2017-04-25 6:13 ` Qu Wenruo
2017-04-26 16:43 ` Fred Van Andel
2017-10-30 3:31 ` Dave
2017-10-30 21:37 ` Chris Murphy
2017-10-31 5:57 ` Marat Khalili
2017-10-31 11:28 ` Austin S. Hemmelgarn
2017-11-03 7:42 ` Kai Krakow
2017-11-03 11:33 ` Austin S. Hemmelgarn
2017-11-03 22:03 ` Chris Murphy [this message]
2017-11-04 4:46 ` Adam Borowski
2017-11-04 12:00 ` Marat Khalili
2017-11-04 17:14 ` Chris Murphy
2017-11-06 13:29 ` Austin S. Hemmelgarn
2017-11-06 18:45 ` Chris Murphy
2017-11-06 19:12 ` Austin S. Hemmelgarn
2017-11-04 7:26 ` Dave
2017-11-04 17:25 ` Chris Murphy
2017-11-07 7:01 ` Dave
2017-11-07 13:02 ` Austin S. Hemmelgarn
2017-11-08 4:50 ` Chris Murphy
2017-11-08 12:13 ` Austin S. Hemmelgarn
2017-11-08 17:17 ` Chris Murphy
2017-11-08 17:22 ` Hugo Mills
2017-11-08 17:54 ` Chris Murphy
2017-11-08 18:10 ` Austin S. Hemmelgarn
2017-11-08 18:31 ` Chris Murphy
2017-11-08 19:29 ` Austin S. Hemmelgarn
2017-10-31 1:58 ` Duncan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJCQCtTT7_pfx5yn--We-kq0XWd38H_Lw1Prbmo5ytkTZWapYQ@mail.gmail.com \
--to=lists@colorremedies.com \
--cc=ahferroin7@gmail.com \
--cc=davestechshop@gmail.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=mkh@rqc.ru \
--cc=vanandel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).