From: Filipe Manana <fdmanana@kernel.org>
To: dsterba@suse.cz, Filipe Manana <fdmanana@kernel.org>,
linux-btrfs <linux-btrfs@vger.kernel.org>
Subject: Re: [PATCH v2] Btrfs: fix race between send and deduplication that lead to failures and crashes
Date: Mon, 13 May 2019 18:05:54 +0100 [thread overview]
Message-ID: <CAL3q7H5v8+A5X4sLS_O2NGYcZxhBKauw4LgbXp+36iHkRow+cw@mail.gmail.com> (raw)
In-Reply-To: <20190513165853.GG3138@twin.jikos.cz>
On Mon, May 13, 2019 at 5:57 PM David Sterba <dsterba@suse.cz> wrote:
>
> On Mon, May 13, 2019 at 05:18:37PM +0100, Filipe Manana wrote:
> > I would leave it as it is unless users start to complain. Yes, the
> > test does this on purpose.
> > Adding such code/state seems weird to me, instead I would change the
> > rate limit state so that the messages would repeat much less
> > frequently.
>
> The difference to the state tracking is that the warning would be
> printed repeatedly, which I find unnecessary and based on past user
> feedback, there will be somebody asking about that.
>
> The rate limiting can also skip a message that can be for a different
> subvolume, so this makes it harder to diagnose problems.
>
> Current state is not satisfactory at least for me because it hurts
> testing, the test runs for about 2 hours now, besides the log bloat. The
You mean the test case for fstests (btrfs/187) takes 2 hours for you?
For me it takes under 8 minutes for an unpatched btrfs, while a
patched btrfs takes somewhere between 1 minute and 3 minutes. This is
on VMs, with a debug kernel, average/cheap host hardware, etc.
> number of messages that slipped through ratelimiting is now over 11k,
> which is roughly 150k messages printed overall.
next prev parent reply other threads:[~2019-05-13 17:06 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-15 8:30 [PATCH] Btrfs: fix race between send and deduplication that lead to failures and crashes fdmanana
2019-04-17 14:11 ` David Sterba
2019-04-22 15:43 ` [PATCH v2] " fdmanana
2019-04-24 16:26 ` David Sterba
2019-05-13 15:56 ` David Sterba
2019-05-13 16:07 ` David Sterba
2019-05-13 16:18 ` Filipe Manana
2019-05-13 16:58 ` David Sterba
2019-05-13 17:05 ` Filipe Manana [this message]
2019-05-13 19:10 ` David Sterba
2019-05-13 22:06 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAL3q7H5v8+A5X4sLS_O2NGYcZxhBKauw4LgbXp+36iHkRow+cw@mail.gmail.com \
--to=fdmanana@kernel.org \
--cc=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).