Re: [PATCH] btrfs: Test if btrfs will report false ENOSPC error balnacing small metadata chunk

[Filipe Manana <fdmanana@gmail.com>]

On Tue, Jan 29, 2019 at 7:28 AM Qu Wenruo <wqu@suse.com> wrote:
>
> This is a long existing bug, caused by over-estimated metadata
> space_info::bytes_may_use.

Nop, this is a test case :)
The sentence should be more like "This is a test case for a long
existing bug, ...".

>
> There is one purposed patch for btrfs-progs to fix it, titled:

purposed -> proposed

> "btrfs-progs: balance: Sync the fs before balancing metadata chunks"
>
> The test case itself is almost the same as btrfs/181, which use small

use -> uses

> files to bump a reserved space to trigger the false alert.

a -> the

Also, for the subject, there's the typo "balnacing".

>
> Signed-off-by: Qu Wenruo <wqu@suse.com>
> ---
>  tests/btrfs/182     | 60 +++++++++++++++++++++++++++++++++++++++++++++
>  tests/btrfs/182.out |  2 ++
>  tests/btrfs/group   |  1 +
>  3 files changed, 63 insertions(+)
>  create mode 100755 tests/btrfs/182
>  create mode 100644 tests/btrfs/182.out
>
> diff --git a/tests/btrfs/182 b/tests/btrfs/182
> new file mode 100755
> index 00000000..61efcb9e
> --- /dev/null
> +++ b/tests/btrfs/182
> @@ -0,0 +1,60 @@
> +#! /bin/bash
> +# SPDX-License-Identifier: GPL-2.0
> +# Copyright (C) 2019 SUSE Linux Products GmbH. All Rights Reserved.
> +#
> +# FS QA Test 182
> +#
> +# Test if balance will report false ENOSPC error
> +#
> +# This is a long existing bug, caused by over-estimated metadata
> +# space_info::bytes_may_use.
> +# There is one purposed patch for btrfs-progs to fix it, titled:

purposed -> proposed

> +# "btrfs-progs: balance: Sync the fs before balancing metadata chunks"
> +#
> +seq=`basename $0`
> +seqres=$RESULT_DIR/$seq
> +echo "QA output created by $seq"
> +
> +here=`pwd`
> +tmp=/tmp/$$
> +status=1       # failure is the default!
> +trap "_cleanup; exit \$status" 0 1 2 3 15
> +
> +_cleanup()
> +{
> +       cd /
> +       rm -f $tmp.*
> +}
> +
> +# get standard environment, filters and checks
> +. ./common/rc
> +. ./common/filter
> +
> +# remove previous $seqres.full before test
> +rm -f $seqres.full
> +
> +# real QA test starts here
> +
> +# Modify as appropriate.
> +_supported_fs btrfs
> +_supported_os Linux
> +_require_scratch
> +
> +nr_files=1024
> +
> +_scratch_mkfs > /dev/null
> +_scratch_mount
> +
> +$BTRFS_UTIL_PROG subv create "$SCRATCH_MNT/subvol" > /dev/null

subv -> subvolume

We always prefer full command names.

Other than that, it looks good.

Reviewed-by: Filipe Manana <fdmanana@suse.com>

> +
> +# Create some small files to take up enough metadata reserved space
> +for ((i = 0; i < $nr_files; i++)) do
> +       _pwrite_byte 0xcd 0 1K "$SCRATCH_MNT/subvol/file_$i" > /dev/null
> +done
> +
> +$BTRFS_UTIL_PROG balance start -m "$SCRATCH_MNT" > /dev/null
> +
> +# success, all done
> +echo "Silence is golden"
> +status=0
> +exit
> diff --git a/tests/btrfs/182.out b/tests/btrfs/182.out
> new file mode 100644
> index 00000000..53d28e50
> --- /dev/null
> +++ b/tests/btrfs/182.out
> @@ -0,0 +1,2 @@
> +QA output created by 182
> +Silence is golden
> diff --git a/tests/btrfs/group b/tests/btrfs/group
> index 0db485cb..e32c84e4 100644
> --- a/tests/btrfs/group
> +++ b/tests/btrfs/group
> @@ -184,3 +184,4 @@
>  179 auto qgroup dangerous
>  180 auto quick qgroup limit
>  181 auto quick balance
> +182 auto quick balance
> --
> 2.18.0
>


-- 
Filipe David Manana,

“Whether you think you can, or you think you can't — you're right.”