* [PATCH] btrfs: adjust error jump position
@ 2022-09-23 14:58 Hao Peng
2022-10-07 16:38 ` David Sterba
0 siblings, 1 reply; 3+ messages in thread
From: Hao Peng @ 2022-09-23 14:58 UTC (permalink / raw)
To: clm, josef, dsterba; +Cc: linux-btrfs
From: Peng Hao <flyingpeng@tencent.com>
Since 'em' has been set to NULL, you can jump directly to out_err.
Signed-off-by: Peng Hao <flyingpeng@tencent.com>
---
fs/btrfs/inode.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/btrfs/inode.c b/fs/btrfs/inode.c
index f0c97d25b4a0..b5c408ed888a 100644
--- a/fs/btrfs/inode.c
+++ b/fs/btrfs/inode.c
@@ -8146,7 +8146,7 @@ static void btrfs_submit_direct(const struct
iomap_iter *iter,
if (IS_ERR(em)) {
status = errno_to_blk_status(PTR_ERR(em));
em = NULL;
- goto out_err_em;
+ goto out_err;
}
ret = btrfs_get_io_geometry(fs_info, em, btrfs_op(dio_bio),
logical, &geom);
--
2.27.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] btrfs: adjust error jump position
2022-09-23 14:58 [PATCH] btrfs: adjust error jump position Hao Peng
@ 2022-10-07 16:38 ` David Sterba
0 siblings, 0 replies; 3+ messages in thread
From: David Sterba @ 2022-10-07 16:38 UTC (permalink / raw)
To: Hao Peng; +Cc: clm, josef, dsterba, linux-btrfs
On Fri, Sep 23, 2022 at 10:58:12PM +0800, Hao Peng wrote:
> From: Peng Hao <flyingpeng@tencent.com>
>
> Since 'em' has been set to NULL, you can jump directly to out_err.
>
> Signed-off-by: Peng Hao <flyingpeng@tencent.com>
So this patch also does not apply and git am complains that the patch is
corrupted. Can you please you're generating the patches correctly?
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] btrfs: adjust error jump position
@ 2022-09-18 7:56 flyingpeng(彭浩)
0 siblings, 0 replies; 3+ messages in thread
From: flyingpeng(彭浩) @ 2022-09-18 7:56 UTC (permalink / raw)
To: clm, josef, dsterba; +Cc: linux-btrfs
Since 'em' has been set to NULL, you can jump directly to out_err.
Signed-off-by: Peng Hao <flyingpeng@tencent.com>
---
fs/btrfs/inode.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/btrfs/inode.c b/fs/btrfs/inode.c
index f0c97d25b4a0..b5c408ed888a 100644
--- a/fs/btrfs/inode.c
+++ b/fs/btrfs/inode.c
@@ -8146,7 +8146,7 @@ static void btrfs_submit_direct(const struct iomap_iter *iter,
if (IS_ERR(em)) {
status = errno_to_blk_status(PTR_ERR(em));
em = NULL;
- goto out_err_em;
+ goto out_err;
}
ret = btrfs_get_io_geometry(fs_info, em, btrfs_op(dio_bio),
logical, &geom);
--
2.27.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-10-07 16:38 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-23 14:58 [PATCH] btrfs: adjust error jump position Hao Peng
2022-10-07 16:38 ` David Sterba
-- strict thread matches above, loose matches on Subject: below --
2022-09-18 7:56 flyingpeng(彭浩)
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).